Add "native_expression.max_array_size_in_reduce" session property.#23846
Merged
amitkdutta merged 1 commit intoprestodb:masterfrom Oct 17, 2024
Conversation
spershin
requested review from
a team,
elharo and
steveburnett
as code owners
spershin
force-pushed
the
AddSessionProp_native_expression.max_array_size_in_reduce
branch
from
7518ddf to
9f7e71e
Compare
steveburnett
requested changes
Oct 16, 2024
Contributor
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
Thanks for the doc! Two suggestions.
spershin
force-pushed
the
AddSessionProp_native_expression.max_array_size_in_reduce
branch
from
9f7e71e to
9526f85
Compare
steveburnett
requested changes
Oct 16, 2024
feilong-liu
previously approved these changes
Oct 16, 2024
6 tasks
spershin
force-pushed
the
AddSessionProp_native_expression.max_array_size_in_reduce
branch
from
9526f85 to
c099fe4
Compare
steveburnett
approved these changes
Oct 16, 2024
Contributor
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull updated branch, new local doc build, tested and verified link in doc. Thanks!
feilong-liu
approved these changes
Oct 16, 2024
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add "native_expression.max_array_size_in_reduce" session property.
It can be used to control the limitation of Prestissimo's implementation of reduce() function.