[docs] Add admin/properties-session.rst#23811
Closed
steveburnett wants to merge 1 commit intoprestodb:masterfrom
Closed
[docs] Add admin/properties-session.rst#23811steveburnett wants to merge 1 commit intoprestodb:masterfrom
steveburnett wants to merge 1 commit intoprestodb:masterfrom
Conversation
6 tasks
tdcmeehan
reviewed
Oct 24, 2024
Contributor
tdcmeehan
left a comment
There was a problem hiding this comment.
Content looks good, let's link between the session properties and the config properties.
6 tasks
Contributor
Author
|
Closing this PR as it's replaced by #23888. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Builds on the work in #23852 by separating the Java session properties in Properties Reference to a separate page.
How I did this:
In the new properties-session.rst:
For each entry in Properties Reference that contained a sentence like
This can also be specified on a per-query basis using the join_distribution_type session property. , I:
For each entry that did not contain a sentence referencing a session property, I deleted the entry.
Exceptions to the above:
task_writer_countandtask_partitioned_writer_countappear to be session properties so I deleted them from this file and included them in properties_session.rst.optimizer.treat-low-confidence-zero-estimation-as-unknownandoptimizer.retry-query-with-history-based-optimizationdescribe thetreat-low-confidence-zero-estimation-as-unknownsession property andretry-query-with-history-based-optimizationsession property, which I am uncertain of because of the use of dashes instead of underscores in their names. I created entries for them in properties-session.rst, but I'd ask those session property names be checked.NOTE: the intended scope of this PR is to separate the session properties doc from the configuration properties doc. I wasn't planning to add new doc for undocumented session properties in this PR, new entries can be added as future doc PRs.
Motivation and Context
Parallelizes the Presto doc with the Presto C++ doc structure in #23852.
Impact
Documentation.
Test Plan
Contributor checklist
Release Notes