Skip to content

Extend MongoDB connector support binData #23386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tdcmeehan merged 1 commit into from
Aug 27, 2024
Merged

Extend MongoDB connector support binData #23386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions presto-mongodb/src/main/java/com/facebook/presto/mongodb/MongoSession.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import com.facebook.presto.common.type.TypeManager;
import com.facebook.presto.common.type.TypeSignature;
import com.facebook.presto.common.type.TypeSignatureParameter;
import com.facebook.presto.common.type.VarbinaryType;
import com.facebook.presto.spi.ColumnHandle;
import com.facebook.presto.spi.PrestoException;
import com.facebook.presto.spi.SchemaNotFoundException;
Expand All @@ -46,6 +47,7 @@
import com.mongodb.client.result.DeleteResult;
import io.airlift.slice.Slice;
import org.bson.Document;
import org.bson.types.Binary;
import org.bson.types.ObjectId;

import java.util.ArrayList;
Expand Down Expand Up @@ -519,6 +521,9 @@ else if (value instanceof Date) {
else if (value instanceof ObjectId) {
typeSignature = OBJECT_ID.getTypeSignature();
}
else if (value instanceof Binary) {
typeSignature = VarbinaryType.VARBINARY.getTypeSignature();
}
else if (value instanceof List) {
List<Optional<TypeSignature>> subTypes = ((List<?>) value).stream()
.map(this::guessFieldType)
Expand Down
13 changes: 13 additions & 0 deletions presto-mongodb/src/test/java/com/facebook/presto/mongodb/TestMongoIntegrationSmokeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,19 @@ public void testObjectIds()
assertOneNotNullResult("SELECT id FROM tmp_objectid WHERE id = ObjectId('ffffffffffffffffffffffff')");
}

@Test
public void testBinarys()
{
assertUpdate("CREATE TABLE tmp_binary AS SELECT cast('value' as varbinary) AS _varbinary", 1);
assertOneNotNullResult("SELECT _varbinary FROM tmp_binary");

MaterializedResult results = getQueryRunner().execute(getSession(), "SELECT _varbinary FROM tmp_binary").toTestTypes();
assertEquals(results.getRowCount(), 1);

MaterializedRow row = results.getMaterializedRows().get(0);
assertEquals(row.getField(0), "value".getBytes(UTF_8));
}

private void assertOneNotNullResult(String query)
{
MaterializedResult results = getQueryRunner().execute(getSession(), query).toTestTypes();
Expand Down
16 changes: 16 additions & 0 deletions presto-mongodb/src/test/java/com/facebook/presto/mongodb/TestMongoSession.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,19 @@
import static com.facebook.presto.common.predicate.Range.lessThan;
import static com.facebook.presto.common.predicate.Range.range;
import static com.facebook.presto.common.type.BigintType.BIGINT;
import static com.facebook.presto.common.type.VarbinaryType.VARBINARY;
import static com.facebook.presto.common.type.VarcharType.createUnboundedVarcharType;
import static io.airlift.slice.Slices.utf8Slice;
import static io.airlift.slice.Slices.wrappedBuffer;
import static java.nio.charset.StandardCharsets.UTF_8;
import static java.util.Arrays.asList;
import static org.testng.Assert.assertEquals;

public class TestMongoSession
{
private static final MongoColumnHandle COL1 = new MongoColumnHandle("col1", BIGINT, false);
private static final MongoColumnHandle COL2 = new MongoColumnHandle("col2", createUnboundedVarcharType(), false);
private static final MongoColumnHandle COL3 = new MongoColumnHandle("col3", VARBINARY, false);

@Test
public void testBuildQuery()
Expand All @@ -52,6 +56,18 @@ public void testBuildQuery()
assertEquals(query, expected);
}

@Test
public void testBuildQueryBinaryType()
{
TupleDomain<ColumnHandle> tupleDomain = TupleDomain.withColumnDomains(ImmutableMap.of(
COL3, Domain.singleValue(VARBINARY, wrappedBuffer("VarBinary Value".getBytes(UTF_8)))));

Document query = MongoSession.buildQuery(tupleDomain);
Document expected = new Document()
.append(COL3.getName(), new Document().append("$eq", "VarBinary Value"));
assertEquals(query, expected);
}

@Test
public void testBuildQueryStringType()
{
Expand Down