Extend MongoDB connector support binData#23084
Closed
exxiang wants to merge 170 commits intoprestodb:masterfrom
Closed
Extend MongoDB connector support binData#23084exxiang wants to merge 170 commits intoprestodb:masterfrom
exxiang wants to merge 170 commits intoprestodb:masterfrom
Conversation
|
|
Contributor
Author
I have add tests. Please preview again. thank u |
elharo
approved these changes
Jun 27, 2024
tdcmeehan
approved these changes
Jul 2, 2024
Contributor
|
Thanks @exxiang ! |
Contributor
Author
you are welcome |
Contributor
|
@exxiang can you please squash the commits? |
…pendent of runtime heap size
To avoid competing with Driver tasks
No need to send an explicit ack when PrestoExchangeSource is active. A subsequent getData request is expected to acknowledge previously received data automatically
Math function `round(x, d)` returns wrong results when `x * (d^10)` is out of the range [Long.MIN_VALUE, Long.MAX_VALUE]. For those input, the result will be capped at `Long.MIN_VALUE/d` or `Long.MAX_VALUE/d`. If `x * (d^10)` is larger than Long.MAX_VALUE or smaller than Long.MIN_VALUE, it should be converted into `BigDecimal` to ensure an accurate result.
The error message for invalid cast from REAL -> BIGINT/INTEGER/SMALLINT/TINYINT was previously returning the integer bits underlying the float instead of the float value itself. This fixes that to use the float value in the error message. For example, casting a NaN value to bigint that was represented as 0xFFC00000 would fail with the message "Unable to cast -4194304 to bigint". Now the error message will say "Unable to cast NaN to bigint".
In this commit, we address the issue where 'presto_protocol.cpp' and 'presto_protocol.h' files change even when there are no new Java side changes, which occurs every time 'make presto_protocol' is executed
Update docker compose scripts for docker compose v2, as legacy docker-compose v1 is no longer supported for github actions.
…ngodb-support-bindata
Contributor
Author
please tell me, my squash is it ok? |
Contributor
|
@exxiang it is not, as there are 167 unrelated commits. This guide may help: https://www.freecodecamp.org/news/git-squash-commits/ |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extend MongoDB connector support binData
Motivation and Context
Extend MongoDB connector support [binData] #23083
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.