Skip to content

Enable ExchangeAsset in asset hubs #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fellowship-merge-bot merged 14 commits into from
May 5, 2025
Merged

Enable ExchangeAsset in asset hubs #700

fellowship-merge-bot merged 14 commits into from
May 5, 2025

Conversation

@franciscoaguirre
Copy link
Contributor

@franciscoaguirre franciscoaguirre commented Apr 30, 2025 •
edited
Loading

ExchangeAsset was missing its benchmark for being enabled in asset hub.
It already has an implementation so it can be used for swapping two assets using the liquidity pools on asset hub.
Addresses #649.
Aiming for release 1.5.1.

@franciscoaguirre
Copy link
Contributor Author

franciscoaguirre commented Apr 30, 2025

/cmd bench --runtime asset-hub-kusama asset-hub-polkadot --pallet pallet_xcm_benchmarks::generic

@github-actions
Copy link

github-actions bot commented Apr 30, 2025

Command "" has started 🚀 See logs here

@github-actions
Copy link

github-actions bot commented Apr 30, 2025

Command "" has finished ✅ See logs here

@franciscoaguirre
Copy link
Contributor Author

franciscoaguirre commented Apr 30, 2025

/cmd bench --runtime asset-hub-kusama asset-hub-polkadot --pallet "pallet_xcm_benchmarks::generic"

@github-actions
Copy link

github-actions bot commented Apr 30, 2025

Command "" has started 🚀 See logs here

@github-actions
Copy link

github-actions bot commented Apr 30, 2025

Command "" has finished ✅ See logs here

@franciscoaguirre
Copy link
Contributor Author

franciscoaguirre commented Apr 30, 2025

/cmd bench --runtime asset-hub-kusama asset-hub-polkadot --pallet pallet_xcm_benchmarks::generic

@github-actions
Copy link

github-actions bot commented Apr 30, 2025

Command "" has started 🚀 See logs here

@github-actions
Copy link

github-actions bot commented Apr 30, 2025

Command "" has finished ✅ See logs here

@franciscoaguirre franciscoaguirre mentioned this pull request Apr 30, 2025
Merged
fellowship-merge-bot bot pushed a commit that referenced this pull request May 1, 2025
@franciscoaguirre
Let "/cmd bench" accept ":" for "pallet_xcm_benchmarks::generic" (#703)
5429d1a 
Trying to use the bench bot for running benchmarks for
"pallet_xcm_benchmarks::generic", I found out the regex in the github
workflow is missing the colon.
This PR aims to unblock
#700 that's aiming to
run those exact benchmarks.
@franciscoaguirre
Copy link
Contributor Author

franciscoaguirre commented May 1, 2025

/cmd bench --runtime asset-hub-kusama asset-hub-polkadot --pallet pallet_xcm_benchmarks::generic

@github-actions
Copy link

github-actions bot commented May 1, 2025

Command "" has started 🚀 See logs here

@github-actions
Copy link

github-actions bot commented May 1, 2025

Command "" has finished ✅ See logs here

@franciscoaguirre
Copy link
Contributor Author

franciscoaguirre commented May 1, 2025

/cmd bench --runtime asset-hub-kusama asset-hub-polkadot --pallet pallet_xcm_benchmarks::generic

@github-actions
Copy link

github-actions bot commented May 1, 2025

Command "" has started 🚀 See logs here

@github-actions
Copy link

github-actions bot commented May 1, 2025

Command "" has finished ✅ See logs here

@franciscoaguirre
Copy link
Contributor Author

franciscoaguirre commented May 1, 2025

/cmd bench --runtime asset-hub-kusama asset-hub-polkadot --pallet pallet_xcm_benchmarks::generic

@franciscoaguirre
Copy link
Contributor Author

franciscoaguirre commented May 2, 2025

/merge

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) May 2, 2025 08:39
@fellowship-merge-bot
Copy link
Contributor

fellowship-merge-bot bot commented May 2, 2025

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

auto-merge was automatically disabled May 2, 2025 08:40

Head branch was pushed to by a user without write access

@franciscoaguirre
Copy link
Contributor Author

franciscoaguirre commented May 2, 2025

/merge

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) May 2, 2025 08:43
@fellowship-merge-bot
Copy link
Contributor

fellowship-merge-bot bot commented May 2, 2025

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

auto-merge was automatically disabled May 2, 2025 08:43

Head branch was pushed to by a user without write access

@franciscoaguirre
Copy link
Contributor Author

franciscoaguirre commented May 2, 2025

/merge

@fellowship-merge-bot
Copy link
Contributor

fellowship-merge-bot bot commented May 2, 2025

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) May 2, 2025 08:49
auto-merge was automatically disabled May 2, 2025 09:06

Head branch was pushed to by a user without write access

@franciscoaguirre
Copy link
Contributor Author

franciscoaguirre commented May 2, 2025

/merge

2 similar comments
@franciscoaguirre
Copy link
Contributor Author

franciscoaguirre commented May 2, 2025

/merge

@franciscoaguirre
Copy link
Contributor Author

franciscoaguirre commented May 2, 2025

/merge

@fellowship-merge-bot
Copy link
Contributor

fellowship-merge-bot bot commented May 2, 2025

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) May 2, 2025 11:54
@fellowship-merge-bot fellowship-merge-bot bot merged commit 5e374f5 into polkadot-fellows:main May 5, 2025
60 of 63 checks passed
@franciscoaguirre franciscoaguirre deleted the enable-exchange-asset-in-asset-hubs branch May 5, 2025 09:23
This was referenced May 5, 2025
Closed
Closed
@bkontur bkontur mentioned this pull request May 6, 2025
Merged
12 tasks
@bkontur bkontur mentioned this pull request Jun 17, 2025
Merged
1 task
ggwpez pushed a commit that referenced this pull request Jun 17, 2025
@bkontur
Set up alias_origin weights correctly (#771)
599383a 
This is leftover from bump stable2412 where we added Aliasers but not
changed weights:
#606
for AssetHub weights were fixed here
#700 but not for other
chains

- [X] Does not require a CHANGELOG entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkchr bkchr bkchr approved these changes

@bkontur bkontur bkontur approved these changes

@joepetrowski joepetrowski joepetrowski approved these changes

@acatangiu acatangiu acatangiu approved these changes

+3 more reviewers

@karolk91 karolk91 karolk91 approved these changes

@x3c41a x3c41a x3c41a approved these changes

@raymondkfcheung raymondkfcheung raymondkfcheung approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@franciscoaguirre @karolk91 @bkchr @bkontur @joepetrowski @acatangiu @x3c41a @raymondkfcheung @actions-user