Upgrade polkadot sdk to stable2412-4 (rel. 1.5.0)
#606
Conversation
Note: This had to be done since there are not updated pallets that could be used for upgrading the runtime. TODO @clangenb: Help updating Encointer to `stable2412`.
Note: includes mocked weights, needs to run proper benches. Note 2: A migration to XCMv5 was started. Do we need anything additional? Note 3: `sp_std` was removed.
Note: includes mocked weights, needs to run proper benches. Note 2: A migration to XCMv5 was started. Do we need anything additional? Note 3: `sp_std` was removed. Note 4: do we still need `coretime_migration.rs`?
Note: includes mocked weights, needs to run proper benches. Note 2: A migration to XCMv5 was started. Do we need anything additional? Note 3: `sp_std` was removed.
Note: includes mocked weights, needs to run proper benches. Note 2: A migration to XCMv5 was started. Do we need anything additional? Note 3: `sp_std` was removed.
Note: includes mocked weights, needs to run proper benches. Note 2: `sp_std` was removed
Note: includes mocked weights, needs to run proper benches. Note 2: `sp_std` was removed
Note: includes mocked weights, needs to run proper benches. Note 2: `sp_std` was removed
Note: includes mocked weights, needs to run proper benches. Note 2: A migration to XCMv5 was started. Do we need anything additional? Note 3: `sp_std` was removed
Note: includes mocked weights, needs to run proper benches. Note 2: A migration to XCMv5 was started. Do we need anything additional? Note 3: `sp_std` was removed
Note: includes mocked weights, needs to run proper benches. Note 3: `sp_std` was removed
Note: includes mocked weights, needs to run proper benches. Note 3: `sp_std` was removed
Note: includes mocked weights, needs to run proper benches. Note 2: `sp_std` was removed
pandres95
changed the title
stable2412-1
|
@pandres95 on-it. I reckon to have a PR by Thursday, the latest. |
# Conflicts: # relay/kusama/src/lib.rs # relay/polkadot/src/lib.rs # system-parachains/asset-hubs/asset-hub-kusama/src/lib.rs # system-parachains/asset-hubs/asset-hub-polkadot/src/lib.rs # system-parachains/bridge-hubs/bridge-hub-kusama/src/lib.rs # system-parachains/bridge-hubs/bridge-hub-polkadot/src/lib.rs # system-parachains/collectives/collectives-polkadot/src/lib.rs # system-parachains/coretime/coretime-kusama/src/lib.rs # system-parachains/coretime/coretime-polkadot/src/lib.rs # system-parachains/gluttons/glutton-kusama/src/lib.rs # system-parachains/people/people-kusama/src/lib.rs # system-parachains/people/people-polkadot/src/lib.rs
|
encointer is ready: pandres95#9 |
* Revert "feat(encointer-kusama-runtime): disable Encointer runtime and pallets." This reverts commit 9303cb3 * bump encointer crates * migrate encointer runtime to stable202412-2 * [encointer] add benchmarking setup for asset_tx_payment * [encointer] fix asset-tx-benchmarks * fmt * remove sp-std from encointer * fix pallet-transaction payment feature propagation
|
Closes #552 Polkadot migration cleanup: pandres95#10 |
|
@pepoviola zombienet-smoke test does not start progressing: It is nothing like before: https://github.com/polkadot-fellows/runtimes/actions/runs/14001583911/job/39208932124 Could there something specific with stable2412 for zombienet? |
| _descendant_origin: &Option<InteriorLocation>, | ||
| _xcm: &Xcm<RuntimeCall>, | ||
| ) -> Weight { | ||
| XcmGeneric::<Runtime>::execute_with_origin() |
There was a problem hiding this comment.
@franciscoaguirre shouldn't we disable this everywhere? or remove execute_with_origin?
There was a problem hiding this comment.
We removed it from the executor anyway. If someone tries to use it it'll just return an error
There was a problem hiding this comment.
aha, ok, I see that patch is here: so the benchmarking will return Weight::MAX right?
Trying some nits here for zombienet smoke: pandres95#24 |
@pepoviola I don't know why, but zombienet smoke test is flaky, I tried coretime-polkadot and previous version with some cumulus based parachain, and it does not produce blocks for parachain: |
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
|
/merge |
|
Enabled Available commands
For more information see the documentation |
fellowship-merge-bot
bot
merged commit aec5376
into
polkadot-fellows:main
pandres95
changed the title
stable2412-4stable2412-4 (rel. 1.5.0)
That weird, can we increase the log (zombienet=debug) to get a more verbose output. I also will try locally. |
@pepoviola I changed the logs, but let's please continue discussion/fixing here: #676 |
17 participants
This Pull Request provides a minimal set of changes to support the upgrade to
stable2412(to the latest available patch).Notable changes
Here are the most notable changes:
sp-stdremoved for every runtime (except Encointer). Now we usecoreorallocinstead.frame_system_extensions,pallet_transaction_payment, andxcmon most runtimes.pallet_identityon People runtimes.Notable TODOs
Review whether we need to make more changes regarding XCMv5(moved to a follow-up PR). @franciscoaguirrepallet-asset-conversion-tx-paymentis not exposed (or at least, is raising errors when trying to add it).polkadot-runtime, do we still needcoretime_migration.rs? @seadandaTransactionExtension@georgepisaltu @gui1117Open Question
frame,#[frame_construct_runtime]and#[derive_impl]since they've already been proven to work?Help needed
Action List
Remove any reference to either(moved to a follow-up PR).NetworkId::WestendandNetworkId::Rococoand replace withNetworkId::ByGenesisstable2412-3Follow-up PRs
ForeignAssetsandAssetConversionto XCMv5.sp-std.