Skip to content

Set up alias_origin weights correctly #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ggwpez merged 2 commits into from
Jun 17, 2025
Merged

Set up alias_origin weights correctly #771

ggwpez merged 2 commits into from
Jun 17, 2025

Conversation

@bkontur
Copy link
Contributor

@bkontur bkontur commented Jun 17, 2025 •
edited
Loading

This is leftover from bump stable2412 where we added Aliasers but not changed weights:
#606
for AssetHub weights were fixed here #700 but not for other chains

  • Does not require a CHANGELOG entry

@bkontur
Copy link
Contributor Author

bkontur commented Jun 17, 2025

This is leftover from bump stable2412 where we added Aliasers but not changed weights:
#606
for AssetHub weights were fixed here #700 but not for other chains

@bkontur
Copy link
Contributor Author

bkontur commented Jun 17, 2025

cc: @franciscoaguirre please double-check

@bkontur
Fix encointer:
9c49c75 
```
fn universal_alias() -> Result<(Location, Junction), BenchmarkError> {
	Err(BenchmarkError::Skip)
}
```
franciscoaguirre
franciscoaguirre approved these changes Jun 17, 2025
View reviewed changes
@franciscoaguirre
Copy link
Contributor

franciscoaguirre commented Jun 17, 2025

Also, should we add bridge hubs here?

@bkontur
Copy link
Contributor Author

bkontur commented Jun 17, 2025

Also, should we add bridge hubs here?

We could, but do we need AliasOrigin for BridgeHubs? I think it was intentionally not added to BHs, do we need it here?
If so, let's do follow-up

@franciscoaguirre
Copy link
Contributor

franciscoaguirre commented Jun 17, 2025

Also, should we add bridge hubs here?

We could, but do we need AliasOrigin for BridgeHubs? I think it was intentionally not added to BHs, do we need it here? If so, let's do follow-up

I don't think it's needed since they're not user facing. Let's keep it like this

@ggwpez ggwpez merged commit 599383a into polkadot-fellows:oty-weights Jun 17, 2025
44 of 63 checks passed
@bkontur bkontur deleted the bko-on-oty-weights branch June 17, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscoaguirre franciscoaguirre franciscoaguirre approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bkontur @franciscoaguirre @ggwpez