Let "/cmd bench" accept ":" for "pallet_xcm_benchmarks::generic"#703
Merged
fellowship-merge-bot[bot] merged 1 commit intoMay 1, 2025
Conversation
ggwpez
approved these changes
Apr 30, 2025
bkontur
approved these changes
Apr 30, 2025
pandres95
approved these changes
Apr 30, 2025
joepetrowski
approved these changes
May 1, 2025
karolk91
approved these changes
May 1, 2025
Contributor
Author
|
/merge |
Contributor
|
Enabled Available commands
For more information see the documentation |
fellowship-merge-bot Bot
pushed a commit
that referenced
this pull request
May 1, 2025
I modified the wrong regex in #703 😅. This PR does the same change but in the correct regex in the workflow file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to use the bench bot for running benchmarks for "pallet_xcm_benchmarks::generic", I found out the regex in the github workflow is missing the colon.
This PR aims to unblock #700 that's aiming to run those exact benchmarks.