Skip to content

Conversation

@bkchr
Copy link
Contributor

@bkchr bkchr commented Feb 27, 2025

There was a bug found in the staking system which needs to be fixed ASAP. This release pulls in changes directly from a custom Polkadot-SDK branch. The changes can be reviewed here.

After approval, this will go out as a release immediately. A full disclosure of the impact of this issue will be released after it was applied on chain.

@kianenigma
Copy link
Contributor

Doing some last checks on this, please wait.

@bkchr
Copy link
Contributor Author

bkchr commented Feb 27, 2025

/merge

@fellowship-merge-bot fellowship-merge-bot bot merged commit 80ee7dc into main Feb 27, 2025
61 of 62 checks passed
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@pandres95
Copy link
Member

@bkchr do you know if these changes will go out soon (maybe in stable2412-3? Apparently, #606 would be blocked until then.

@bkchr
Copy link
Contributor Author

bkchr commented Mar 11, 2025

@Ank4n can answer this. I requested that this gets backported, but I don't know if this already happened.

@bkchr bkchr deleted the bkchr-fix-the-thing branch March 11, 2025 19:15
@Ank4n
Copy link
Contributor

Ank4n commented Mar 12, 2025

@bkchr do you know if these changes will go out soon (maybe in stable2412-3? Apparently, #606 would be blocked until then.

@pandres95 it is already backported in the stable2412 branch and should be included in the next 2412 release.

As part of this change, we will need to setup a filter (associated function) for pallet_staking as shown in this example.

@seadanda
Copy link
Contributor

should be included in the next 2412 release

It will be included as part of the 2412 patch release next Thursday (20th)

@bkontur bkontur mentioned this pull request Mar 14, 2025
3 tasks
fellowship-merge-bot bot pushed a commit that referenced this pull request Apr 7, 2025
This PR contains:
- bump to stable2409-6

## TODO: 
- [x] fix penpal-runtime compilation
https://github.com/polkadot-fellows/runtimes/actions/runs/13853959747/job/38766523729?pr=623
- [x] check electra setup
- [x] confirm that this PR is compatible and doing the same as
#608 (@Ank4n)

---------

Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: Clara van Staden <[email protected]>
Co-authored-by: Ankan <[email protected]>
pandres95 pushed a commit to pandres95/runtimes that referenced this pull request Apr 7, 2025
* Bump to stable2409-6 (polkadot-fellows#623)

This PR contains:
- bump to stable2409-6

## TODO: 
- [x] fix penpal-runtime compilation
https://github.com/polkadot-fellows/runtimes/actions/runs/13853959747/job/38766523729?pr=623
- [x] check electra setup
- [x] confirm that this PR is compatible and doing the same as
polkadot-fellows#608 (@Ank4n)

---------

Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: Clara van Staden <[email protected]>
Co-authored-by: Ankan <[email protected]>

* Format

---------

Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: Clara van Staden <[email protected]>
Co-authored-by: Ankan <[email protected]>
@anaelleltd anaelleltd moved this from Todo to Done in Runtime releases Apr 16, 2025
fellowship-merge-bot bot pushed a commit that referenced this pull request Apr 16, 2025
This Pull Request provides a minimal set of changes to support the
upgrade to `stable2412` (to the latest available patch).

## Notable changes

Here are the most notable changes:

- `sp-std` removed for every runtime (except Encointer). Now we use
`core` or `alloc` instead.
- Mocked weights for `frame_system_extensions`,
`pallet_transaction_payment`, and `xcm` on most runtimes.
- Mocked weights for `pallet_identity` on People runtimes.
- Update to XCMv5 started.

## Notable TODOs

- [x] ~Review whether we need to make more changes regarding XCMv5~
(moved to a follow-up PR). @franciscoaguirre
- [x] In Asset Hubs, the benchmarking options for
`pallet-asset-conversion-tx-payment` is not exposed (or at least, is
raising errors when trying to add it).
- [x] For `polkadot-runtime`, do we still need `coretime_migration.rs`?
@seadanda
- [x] Assist with the initial implementation of `TransactionExtension`
@georgepisaltu @gui1117

## Open Question

- Shouldn't we start using `frame`, `#[frame_construct_runtime]` and
`#[derive_impl]` since they've already been proven to work?

## Help needed

- [x] @clangenb to update and re-enable Encointer.

## Action List

- [x] ~Remove any reference to either `NetworkId::Westend` and
`NetworkId::Rococo` and replace with `NetworkId::ByGenesis`~ (moved to a
follow-up PR).
- [x] Upgrade to `stable2412-3`
- [x] Setup filter for pallet-staking to exclude pool members. See
comment
[here](#608 (comment)).

## Follow-up PRs

- [ ] Refresh weights (to do before this release). ;)
- [ ] Move to XCMv5.
- [ ] Remove `sp-std`.

---------

Signed-off-by: Andrei Sandu <[email protected]>
Co-authored-by: clangenb <[email protected]>
Co-authored-by: Dónal Murray <[email protected]>
Co-authored-by: Francisco Aguirre <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Andrei Sandu <[email protected]>
Co-authored-by: Clara van Staden <[email protected]>
Co-authored-by: Andrei Sandu <[email protected]>
Co-authored-by: Branislav Kontur <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: Ankan <[email protected]>
Co-authored-by: Alexandre Baldé <[email protected]>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this pull request Jul 3, 2025
This Pull Request provides a minimal set of changes to support the
upgrade to `stable2412` (to the latest available patch).

## Notable changes

Here are the most notable changes:

- `sp-std` removed for every runtime (except Encointer). Now we use
`core` or `alloc` instead.
- Mocked weights for `frame_system_extensions`,
`pallet_transaction_payment`, and `xcm` on most runtimes.
- Mocked weights for `pallet_identity` on People runtimes.
- Update to XCMv5 started.

## Notable TODOs

- [x] ~Review whether we need to make more changes regarding XCMv5~
(moved to a follow-up PR). @franciscoaguirre
- [x] In Asset Hubs, the benchmarking options for
`pallet-asset-conversion-tx-payment` is not exposed (or at least, is
raising errors when trying to add it).
- [x] For `polkadot-runtime`, do we still need `coretime_migration.rs`?
@seadanda
- [x] Assist with the initial implementation of `TransactionExtension`
@georgepisaltu @gui1117

## Open Question

- Shouldn't we start using `frame`, `#[frame_construct_runtime]` and
`#[derive_impl]` since they've already been proven to work?

## Help needed

- [x] @clangenb to update and re-enable Encointer.

## Action List

- [x] ~Remove any reference to either `NetworkId::Westend` and
`NetworkId::Rococo` and replace with `NetworkId::ByGenesis`~ (moved to a
follow-up PR).
- [x] Upgrade to `stable2412-3`
- [x] Setup filter for pallet-staking to exclude pool members. See
comment
[here](polkadot-fellows/runtimes#608 (comment)).

## Follow-up PRs

- [ ] Refresh weights (to do before this release). ;)
- [ ] Move to XCMv5.
- [ ] Remove `sp-std`.

---------

Signed-off-by: Andrei Sandu <[email protected]>
Co-authored-by: clangenb <[email protected]>
Co-authored-by: Dónal Murray <[email protected]>
Co-authored-by: Francisco Aguirre <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Andrei Sandu <[email protected]>
Co-authored-by: Clara van Staden <[email protected]>
Co-authored-by: Andrei Sandu <[email protected]>
Co-authored-by: Branislav Kontur <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: Ankan <[email protected]>
Co-authored-by: Alexandre Baldé <[email protected]>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

10 participants