Merged
Conversation
Tags are now systematically taken as numerical in geometry processing (this is convenient for splitting fractures etc.) and Enums in the interface to Gmsh. Also typing.
Python and mypy seems to want this.
Co-authored-by: Ivar Stefansson <ivar.stefansson@uib.no>
Allow for tolerance specification in `domain_boundary_sides()`
MAINT: Refactor of domain boundary sides
* DOCS: Update docs of some AD objects. * MAINT: Typing and docstrings of some AD objects. * Update src/porepy/numerics/ad/operator_functions.py Co-authored-by: Eirik Keilegavlen <Eirik.Keilegavlen@uib.no> * STY: Return type in ADMethod.ad_wrapper fixed (mypy). * STY: ambigous return type of Operator.evaluate Co-authored-by: Eirik Keilegavlen <Eirik.Keilegavlen@uib.no>
MAINT: synchronize develop and docs
keileg
approved these changes
Nov 25, 2022
Contributor
keileg
left a comment
There was a problem hiding this comment.
Only changes to docs and files that are rebased from develop. Good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Note:
Hyperlinking to type aliases is an open issue on Sphinx' side
sphinx-doc/sphinx#10785