Skip to content

Allow for tolerance specification in domain_boundary_sides()#761

Merged
jhabriel merged 3 commits intodevelopfrom
feat_domain_boundary_size
Nov 9, 2022
Merged

Allow for tolerance specification in domain_boundary_sides()#761
jhabriel merged 3 commits intodevelopfrom
feat_domain_boundary_size

Conversation

@jhabriel
Copy link
Contributor

@jhabriel jhabriel commented Nov 8, 2022

Proposed changes

This small PR aims at increasing the flexibility of the domain_boundary_sides() method by allowing for specification of a tolerance instead of hardcoding a value.

In addition, documentation and typing has been updated to current standards.

Types of changes

What types of changes does this PR introduce to PorePy?
Put an x in the boxes that apply

  • Minor change (e.g., dependency bumps, broken links, etc).
  • Bugfix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Testing (contribution related to testing of existing or new functionality).
  • Documentation (contribution related to adding, improving, or fixing documentation).
  • Maintenance (e.g., improve logic and performance, remove obsolete code, etc).
  • Other:

Checklist

Put an x in the boxes that apply or explain briefly why the box is not relevant.

  • The documentation is up-to-date.
  • Static typing is included in the update.
  • This PR does not duplicated existing functionality.
  • The update is covered by the test suite (including tests added in the PR).

@jhabriel jhabriel added enhancement New feature or request. review - short Short size review effort of a PR ~ minutes. labels Nov 8, 2022
@jhabriel jhabriel requested a review from keileg as a code owner November 8, 2022 23:02
@jhabriel jhabriel self-assigned this Nov 8, 2022
@jhabriel jhabriel merged commit 1533c7e into develop Nov 9, 2022
@jhabriel jhabriel deleted the feat_domain_boundary_size branch November 9, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request. review - short Short size review effort of a PR ~ minutes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants