Conversation
Tags are now systematically taken as numerical in geometry processing (this is convenient for splitting fractures etc.) and Enums in the interface to Gmsh. Also typing.
Python and mypy seems to want this.
Co-authored-by: Ivar Stefansson <ivar.stefansson@uib.no>
Allow for tolerance specification in `domain_boundary_sides()`
MAINT: Refactor of domain boundary sides
* DOCS: Update docs of some AD objects. * MAINT: Typing and docstrings of some AD objects. * Update src/porepy/numerics/ad/operator_functions.py Co-authored-by: Eirik Keilegavlen <Eirik.Keilegavlen@uib.no> * STY: Return type in ADMethod.ad_wrapper fixed (mypy). * STY: ambigous return type of Operator.evaluate Co-authored-by: Eirik Keilegavlen <Eirik.Keilegavlen@uib.no>
vlipovac
commented
Nov 14, 2022
Contributor
Author
There was a problem hiding this comment.
This synchronization involves
- a general update to the latest code in src/
- eliminating the discrepancy in return types which was noticed in #763
- updating code ownership of docs/
Note that GH does not let me make an approval for a PR into docs.
Is this related due to changes happening in directories which are not in docs/?
Or due to the missing update of ownership to docs/?
We can also use this PR to update the workflows for including an auto PR of develop into docs every time develop is updated.
IvarStefansson
approved these changes
Nov 17, 2022
vlipovac
added a commit
that referenced
this pull request
Nov 25, 2022
MAINT: synchronize develop and docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual synchronization of docs with develop until workflow is established.