Merged
Conversation
keileg
reviewed
Nov 9, 2022
Contributor
keileg
left a comment
There was a problem hiding this comment.
One minor comment. Besides: Thanks!
Co-authored-by: Eirik Keilegavlen <Eirik.Keilegavlen@uib.no>
Contributor
Author
|
@keileg are the mypy issues still present? |
Contributor
Checks pass on develop. So updating from develop should suffice. |
Contributor
Author
My bad, there was a return type annotation which was not in develop and which caused mistakes in the discretization file. |
keileg
approved these changes
Nov 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed with @keileg , in order to establish the new workflow with regards to the docs branch, here an update to docstrings and type annotations of some AD classes and functions.
(src code synchronization with docs).
Types of changes
Checklist
Put an
xin the boxes that apply or explain briefly why the box is not relevant.