fix: BodyClass depending on sections

[giuliaghisini]

When you search for a string with spaces in search site, page brokes because section body class is wrong calculated

• I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
• I verified there aren't other open pull requests for the same change.
• I followed the guidelines in Contributing to Volto.
• I succesfully ran code linting checks on my changes locally.
• I succesfully ran unit tests on my changes locally.
• I succesfully ran acceptance tests on my changes locally.
• If needed, I added new tests for my changes.
• If needed, I added documentation for my changes, either in the Storybook or narrative documentation.
• I included a change log entry in my commits.

---

If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #

[netlify]

✅ Deploy Preview for plone-components canceled.

Name	Link
🔨 Latest commit	68e1183
🔍 Latest deploy log	https://app.netlify.com/sites/plone-components/deploys/673b4678fd15250009d1af97

[stevepiercy]

News looks good.

This PR needs a technical review from @plone/volto-team. I'm not sure whether this is a breaking change.

@giuliaghisini can you explain the issue that this PR solves?

[ichim-david]

@stevepiercy technically speaking it should replace all values of space with -. It's stupid that js has replace and replaceAll as such if you have more than one space only the first is replaced.
Concerning the search results I did a search and I've noticed the spaces
https://volto.demo.plone.org/search?SearchableText=News%20Page%20With%20Spaces

Personally, I don't understand why we would set the searchable text as body classes.
is-adding-contenttype-?searchabletext=newspage with spaces
but maybe @sneridagh can enlighten me :)

[stevepiercy]

Personally, I don't understand why we would set the searchable text as body classes.

Other than it might have been a carryover from Classic UI, it is common with search engine indexing to specify the parts of the page that are indexible. Usually they exclude navigation, headers, footers, and other site-wide elements, and include <title>, <article>, or <main>. I think classes provide flexibility.

[davisagli]

Personally, I don't understand why we would set the searchable text as body classes.
is-adding-contenttype-?searchabletext=newspage with spaces

That clearly looks like a bug to me. That code is trying to add a class for the Add view only, including the name of the content type being added -- but it's missing a conditional to only do it there.

it is common with search engine indexing to specify the parts of the page that are indexible. Usually they exclude navigation, headers, footers, and other site-wide elements, and include <title>,

, or

TIL, but I don't really see how that's related to this class.

[giuliaghisini]

@stevepiercy technically speaking it should replace all values of space with -. It's stupid that js has replace and replaceAll as such if you have more than one space only the first is replaced. Concerning the search results I did a search and I've noticed the spaces https://volto.demo.plone.org/search?SearchableText=News%20Page%20With%20Spaces

Personally, I don't understand why we would set the searchable text as body classes. is-adding-contenttype-?searchabletext=newspage with spaces but maybe @sneridagh can enlighten me :)

the problem was exactly this one :-D.
I didn't understand too why searchable text is transformed in a body class.. for me it doesn't make sense..
let's see if @sneridagh knows why..

[ichim-david]

@giuliaghisini @davisagli marked it as a bug and I assume that so would @sneridagh. Would you be willing since you are here to also ensure this doesn't happen in this pull request if Victor also confirms this as a bug?

[stevepiercy]

This PR resolves the issue with replacing multiple spaces with -, but not the issue with the funky class. @sneridagh will comment on that separately. Let's capture that in a new issue and add it to the Volto Team Meeting project.

[sneridagh]

@ichim-david @giuliaghisini yeah, looks like a bug and we should address it in other PR.