Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dutch Translations update. #6476

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Dutch Translations update. #6476

merged 3 commits into from
Nov 8, 2024

Conversation

fredvd
Copy link
Member

@fredvd fredvd commented Nov 7, 2024

Contributed to by the Flemish Environment…

These are translations only. I tried to run the linting etc. by following the instructions at https://6.docs.plone.org/volto/contributing/developing-core.html and then run 'pnpm lint', in the packages/volto directory but I get a message that more than 10 errors are present. Also my pnpm-lock.yaml file gets local changes when I have pulled out the latest main and am using corepack to pick the correct pnpm version:

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index d17950b41..f4ff0050c 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -25399,7 +25399,7 @@ snapshots:

   [email protected](@babel/[email protected]):
     dependencies:
-      '@babel/compat-data': 7.25.8
+      '@babel/compat-data': 7.24.4

Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 64dca94
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/672cb299d7fa95000847864c

@davisagli
Copy link
Member

@fredvd Hmm. I don't get any changes in pnpm-lock.yml when I install with Node 22, but I get a different error when I try to run pnpm lint inside packages/volto:

> @plone/[email protected] lint /Users/davisagli/Code/volto/packages/volto
> eslint --max-warnings=0 'src/**/*.{js,jsx,ts,tsx,json}'

=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=4.7.4 <5.5.0

YOUR TYPESCRIPT VERSION: 5.6.3

Please only submit bug reports when using the officially supported version.

=============

@sneridagh ??

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fredvd needs a changelog. it's probably best to sort out your trouble with pnpm lint as a separate issue; I don't think that does anything with the locales anyway.

@fredvd
Copy link
Member Author

fredvd commented Nov 7, 2024

I added towmcrier files for volto and 3rd commit for volto-slate subpackage.

Locally I’m using Node 20 indeed, not 22 LTS.

@davisagli davisagli merged commit ee572e0 into main Nov 8, 2024
66 of 68 checks passed
@davisagli davisagli deleted the nl_translations branch November 8, 2024 06:08
sneridagh pushed a commit that referenced this pull request Nov 17, 2024
sneridagh added a commit that referenced this pull request Nov 21, 2024
* main:
  Release 18.1.1
  Release @plone/providers 1.0.0-alpha.6
  Release @plone/components 2.2.0
  [components] Update RAC to 1.5.0, fix Disclosure import (#6498)
  Update instructions to install pipx in `RELEASING.md` (#6496)
  Refactor documentation includes to align with main documentation pattern (#6495)
  More privacy concerning youtube links and fixing link check warnings for youtube playlist links (#6494)
  fix: BodyClass depending on sections (#6487)
  Do not break toolbar if layout id is not registerd in layoutViewsNamesMapping (#6485)
  Add support for sphinxcontrib-youtube and alt tags for videos (#6486)
  Remove conflicting searchtools.js file for documentation (#6482)
  Release 18.1.0
  Release @plone/slate 18.0.1
  Add missing style Helmet serialization in the HTML component to make it work in SSR too (#6480)
  fix locales
  Dutch Translations update.  (#6476)
  Docs 6472 tidy (#6475)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants