Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is-adding-contenttype bodyclass is dragging the querystring with it #6493

Open
sneridagh opened this issue Nov 19, 2024 · 1 comment
Open

Comments

@sneridagh
Copy link
Member

          @stevepiercy technically speaking it should replace all values of space with -. It's stupid that js has replace and replaceAll as such if you have more than one space only the first is replaced.

Concerning the search results I did a search and I've noticed the spaces
https://volto.demo.plone.org/search?SearchableText=News%20Page%20With%20Spaces
search-body-classes

Personally, I don't understand why we would set the searchable text as body classes.
is-adding-contenttype-?searchabletext=newspage with spaces
but maybe @sneridagh can enlighten me :)

Originally posted by @ichim-david in #6487 (comment)

@github-project-automation github-project-automation bot moved this to Needs discussion in Volto Team Meeting Nov 19, 2024
@sneridagh sneridagh moved this from Needs discussion to Plan approved in Volto Team Meeting Nov 19, 2024
@stevepiercy
Copy link
Collaborator

@kaushik7kk please read and follow First-time contributors, especially Things not to do, Contributing to Plone, and Contributing to Volto.

Also using your super power of observation, you may see that the green "Open" icon reflects its status.

@plone plone deleted a comment from kaushik7kk Nov 26, 2024
@plone plone deleted a comment from kaushik7kk Nov 26, 2024
@plone plone deleted a comment from prreyanshu Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Plan approved
Development

No branches or pull requests

3 participants