Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BodyClass depending on sections #6487

Merged
merged 3 commits into from
Nov 19, 2024
Merged

fix: BodyClass depending on sections #6487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
752eef9
fix: BodyClass depending on sections
giuliaghisini Nov 18, 2024
51980c5
Create 6487.bugfix
giuliaghisini Nov 18, 2024
68e1183
Update packages/volto/news/6487.bugfix
giuliaghisini Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/volto/news/6487.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Replace _all_ spaces with `-` in `BodyClass` classes, instead of with `-` or `` depending on the content type or section. @giuliaghisini
4 changes: 2 additions & 2 deletions packages/volto/src/components/theme/App/App.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ export class App extends Component {
{this.props.content && this.props.content['@type'] && (
<BodyClass
className={`contenttype-${this.props.content['@type']
.replace(' ', '-')
.replaceAll(' ', '-')
.toLowerCase()}`}
/>
)}
Expand All @@ -155,7 +155,7 @@ export class App extends Component {
[`is-adding-contenttype-${decodeURIComponent(
this.props.location?.search?.replace('?type=', ''),
)
.replace(' ', '')
.replaceAll(' ', '-')
.toLowerCase()}`]: this.props.location?.search,
'is-authenticated': !!this.props.token,
'is-anonymous': !this.props.token,
Expand Down
Loading