Skip to content

Add proto message for better running version of applicaion #3307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pipecd-bot merged 3 commits into from
Feb 22, 2022
Merged

Add proto message for better running version of applicaion #3307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db7b5f7
Add message for running version of applicaion
ffjlabo Feb 22, 2022
7d02986
Fix ApplicationComponentVersion to ArtifactVersion
ffjlabo Feb 22, 2022
b80342c
Set default value to versionsList
ffjlabo Feb 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/app/web/src/__fixtures__/dummy-application.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ export const dummyApplication: Application.AsObject = {
version: "v1",
trigger: dummyTrigger,
configFilename: "",
versionsList: []
},
mostRecentlyTriggeredDeployment: {
deploymentId: "deployment-1",
Expand All @@ -56,6 +57,7 @@ export const dummyApplication: Application.AsObject = {
version: "v1",
trigger: dummyTrigger,
configFilename: "",
versionsList: []
},
syncState: dummyApplicationSyncState,
updatedAt: updatedAt.unix(),
Expand Down
13 changes: 13 additions & 0 deletions pkg/model/application.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,25 @@ message ApplicationSyncState {
int64 timestamp = 5 [(validate.rules).int64.gt = 0];
}

message ArtifactVersion {
enum Kind {
UNKNOWN = 0;
CONTAINER_IMAGE = 1;
}

Kind kind = 1 [(validate.rules).enum.defined_only = true];
string version = 2 [(validate.rules).string.min_len = 1];
string name = 3;
string url = 4;
}

message ApplicationDeploymentReference {
string deployment_id = 1 [(validate.rules).string.min_len = 1];
DeploymentTrigger trigger = 2 [(validate.rules).message.required = true];
string summary = 3;
string version = 4;
string config_filename = 5;
Copy link
Member

@nghialv nghialv Feb 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The index number must be kept in order to avoid breaking change.
It means that with this change, the old Piped can not talk with the new server which is running with the new data layout.

Copy link
Member Author

@ffjlabo ffjlabo Feb 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. I'll fix it!

repeated ArtifactVersion versions = 6;

int64 started_at = 14 [(validate.rules).int64.gt = 0];
int64 completed_at = 15 [(validate.rules).int64.gte = 0];
Expand Down