Add AllowStrayAsViewer option #2370

khanhtc1202 · 2021-08-19T04:46:45Z

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Add an option to allow users not belonging to any registered teams to log in

pipecd-bot · 2021-08-19T04:56:14Z

Code coverage for golang is 32.10%. This pull request increases coverage by 0.02%.

File	Function	Base	Head	Diff
pkg/oauth/github/github.go	OAuthClient.decideRole	`94.74%`	`95.45%`	`+0.72%`

pkg/model/project.proto

pipecd-bot · 2021-08-19T05:55:44Z

Code coverage for golang is 32.10%. This pull request increases coverage by 0.02%.

File	Function	Base	Head	Diff
pkg/oauth/github/github.go	OAuthClient.decideRole	`94.74%`	`95.45%`	`+0.72%`

khanhtc1202 · 2021-08-19T05:57:13Z

/hold

pkg/model/project.proto

Co-authored-by: Ryo Nakao <[email protected]>

pipecd-bot · 2021-08-19T06:04:44Z

Code coverage for golang is 32.10%. This pull request increases coverage by 0.02%.

File	Function	Base	Head	Diff
pkg/oauth/github/github.go	OAuthClient.decideRole	`94.74%`	`95.45%`	`+0.72%`

pipecd-bot · 2021-08-19T06:08:59Z

Code coverage for javascript is 84.50%. This pull request increases coverage by 0.00%.

File	Base	Head	Diff
src/fixtures/dummy-project.ts	`100.00%`	`100.00%`	`+0.00%`

nghialv · 2021-08-19T06:12:32Z

Nice adding.
/lgtm

pipecd-bot · 2021-08-19T07:25:45Z

Code coverage for golang is 32.10%. This pull request increases coverage by 0.02%.

File	Function	Base	Head	Diff
pkg/oauth/github/github.go	OAuthClient.decideRole	`94.74%`	`95.45%`	`+0.72%`

pipecd-bot · 2021-08-19T07:28:14Z

Code coverage for javascript is 84.50%. This pull request increases coverage by 0.00%.

File	Base	Head	Diff
src/fixtures/dummy-project.ts	`100.00%`	`100.00%`	`+0.00%`

khanhtc1202 · 2021-08-19T08:10:55Z

/hold cancel

khanhtc1202 · 2021-08-19T08:15:19Z

@nghialv @nakabonne I moved the previous flag ProjectRBACConfig.viewer_role_as_default to Project.allow_stray_as_viewer since in case we adopt the ProjectRBACConfig.viewer_role_as_default, we need to add value for ProjectRBACConfig.admin field (it's required on project rbac creation - ref project.proto). After thinking twice, I guess we should keep the project creation form as simple as possible (should not force operators to config their admin team on creation, keep it as simple as we do now), so moving the above flag to Project.allow_stray_as_viewer is a good option, PTAL 🙏

pkg/oauth/github/github.go

Co-authored-by: Ryo Nakao <[email protected]>

pipecd-bot · 2021-08-19T08:24:13Z

Code coverage for golang is 32.10%. This pull request increases coverage by 0.02%.

File	Function	Base	Head	Diff
pkg/oauth/github/github.go	OAuthClient.decideRole	`94.74%`	`95.45%`	`+0.72%`

nakabonne · 2021-08-19T08:25:27Z

/lgtm

nghialv · 2021-08-19T08:27:40Z

pkg/app/ops/handler/templates/AddProject

    <label>Shared SSO</label>
    <input type="text" name="SharedSSO"><br><br>
+    <input type="checkbox" id="auto-assign" name="ViewerRoleAsDefault">
+    <label for="auto-assign">Auto assign viewer role</label><br><br>


Fix the name and label around this part.

nghialv · 2021-08-19T08:28:15Z

pkg/app/ops/handler/handler.go

+		id                  = r.FormValue("ID")
+		description         = r.FormValue("Description")
+		sharedSSOName       = r.FormValue("SharedSSO")
+		viewerRoleAsDefault = r.FormValue("ViewerRoleAsDefault") == "on"


Fix this name too.

Nice catch, addressed on b9eb3fe 🙏

pipecd-bot · 2021-08-19T08:30:44Z

Code coverage for javascript is 84.45%. This pull request decreases coverage by -0.05%.

File	Base	Head	Diff
src/fixtures/dummy-project.ts	`100.00%`	`100.00%`	`+0.00%`
src/modules/project/index.ts	`60.38%`	`56.60%`	`-3.77%`

…add-viewer-as-default

nghialv · 2021-08-19T08:39:04Z

Thank you.
/approve

pipecd-bot · 2021-08-19T08:39:06Z

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

pipecd-bot · 2021-08-19T08:42:59Z

Code coverage for golang is 32.10%. This pull request increases coverage by 0.02%.

File	Function	Base	Head	Diff
pkg/oauth/github/github.go	OAuthClient.decideRole	`94.74%`	`95.45%`	`+0.72%`

pipecd-bot · 2021-08-19T08:46:59Z

Code coverage for javascript is 84.50%. This pull request increases coverage by 0.00%.

File	Base	Head	Diff
src/fixtures/dummy-project.ts	`100.00%`	`100.00%`	`+0.00%`

khanhtc1202 · 2021-08-19T13:32:02Z

/changelog

pipecd-bot · 2021-08-19T13:32:05Z

@khanhtc1202: Changelog has been generated in response to this comment.

Details

Changelog since v0.14.0

Notable Changes

Add an option to allow users not belonging to any registered teams to log in (#2370)
Add a new ops job to clean stale plan-preview outputs (#2356)
Add text regex support for Event watcher (#2347)

Internal Changes

Update documentation for monitoring (#2366)
Update ops to run planpreview cleaner at a fixed time (#2368)
Add project label to piped metrics (#2367)
Add Event watcher example using regex (#2365)
Add settings to talk to Alertmanager (#2364)
Fix typo on helm template (#2363)
Add Cloud SQL Proxy as server and ops sidecar (#2362)
Add sql service account (#2361)
Disallow to update Grafana UI from the web (#2360)
Fix a typo (#2359)
Update lambda deployment feature status (#2358)

Add viewerRoleAsDefault option

59af629

pipecd-bot added area/ops area/web size/M labels Aug 19, 2021

pipecd-bot requested review from nakabonne and nghialv August 19, 2021 04:46

nghialv reviewed Aug 19, 2021

View reviewed changes

pkg/model/project.proto Outdated Show resolved Hide resolved

Fix test

3717639

pipecd-bot added the do-not-merge/hold label Aug 19, 2021

nakabonne reviewed Aug 19, 2021

View reviewed changes

pkg/model/project.proto Outdated Show resolved Hide resolved

Update pkg/model/project.proto

5de58ea

Co-authored-by: Ryo Nakao <[email protected]>

pipecd-bot added the lgtm label Aug 19, 2021

Change flag

0691f3a

pipecd-bot added area/api and removed lgtm labels Aug 19, 2021

pipecd-bot removed the do-not-merge/hold label Aug 19, 2021

nakabonne reviewed Aug 19, 2021

View reviewed changes

pkg/oauth/github/github.go Outdated Show resolved Hide resolved

Update pkg/oauth/github/github.go

20759f8

Co-authored-by: Ryo Nakao <[email protected]>

pipecd-bot added the lgtm label Aug 19, 2021

nghialv reviewed Aug 19, 2021

View reviewed changes

khanhtc1202 changed the title ~~Add viewerRoleAsDefault option~~ Add AllowStrayAsViewer option Aug 19, 2021

khanhtc1202 added 2 commits August 19, 2021 17:35

Rename form field

b9eb3fe

Merge branch 'add-viewer-as-default' of github.com:pipe-cd/pipe into …

ed384c3

…add-viewer-as-default

pipecd-bot removed the lgtm label Aug 19, 2021

pipecd-bot added the approved label Aug 19, 2021

pipecd-bot merged commit bcb1483 into master Aug 19, 2021

pipecd-bot deleted the add-viewer-as-default branch August 19, 2021 08:47

Add AllowStrayAsViewer option #2370

Add AllowStrayAsViewer option #2370

Uh oh!

Conversation

khanhtc1202 commented Aug 19, 2021

Uh oh!

pipecd-bot commented Aug 19, 2021

Uh oh!

Uh oh!

pipecd-bot commented Aug 19, 2021

Uh oh!

khanhtc1202 commented Aug 19, 2021

Uh oh!

Uh oh!

pipecd-bot commented Aug 19, 2021

Uh oh!

pipecd-bot commented Aug 19, 2021

Uh oh!

nghialv commented Aug 19, 2021

Uh oh!

pipecd-bot commented Aug 19, 2021

Uh oh!

pipecd-bot commented Aug 19, 2021

Uh oh!

khanhtc1202 commented Aug 19, 2021

Uh oh!

khanhtc1202 commented Aug 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

pipecd-bot commented Aug 19, 2021

Uh oh!

nakabonne commented Aug 19, 2021

Uh oh!

nghialv Aug 19, 2021

Choose a reason for hiding this comment

Uh oh!

nghialv Aug 19, 2021

Choose a reason for hiding this comment

Uh oh!

khanhtc1202 Aug 19, 2021

Choose a reason for hiding this comment

Uh oh!

pipecd-bot commented Aug 19, 2021

Uh oh!

nghialv commented Aug 19, 2021

Uh oh!

pipecd-bot commented Aug 19, 2021

Uh oh!

pipecd-bot commented Aug 19, 2021

Uh oh!

pipecd-bot commented Aug 19, 2021

Uh oh!

khanhtc1202 commented Aug 19, 2021

Uh oh!

pipecd-bot commented Aug 19, 2021

Changelog since v0.14.0

Notable Changes

Internal Changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

khanhtc1202 commented Aug 19, 2021 •

edited

Loading