-
Notifications
You must be signed in to change notification settings - Fork 204
Add sql service account #2361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sql service account #2361
Conversation
|
Code coverage for golang is
|
|
/lgtm |
manifests/pipecd/values.yaml
Outdated
| gcsServiceAccount: | ||
| fileName: "gcs-service-account" | ||
| data: "" | ||
| sqlServiceAccount: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: cloudSQLServiceAccount? We're going to support the authentication for Amazon RDS, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're going to support the authentication for Amazon RDS, right?
Well, this change is for authorization, not authentication. And I've not looked at Amazon RDS connect method yet, but basically, we only support authentication RDS by username/password as we do for now, this service account is specific for connect to GCP cloud SQL only 🙏
About the name change, I will adopt your suggestion since it would be better to clearly mention that this is only for cloud SQL as you said 🙆♀️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed by 48309ff 🙏
|
Thank you |
|
Code coverage for golang is
|
What this PR does / why we need it:
Add sqlServiceAccount as helm values. It will be used to enable connect from PipeCD workload to GCP Cloud SQL using Cloud SQL Auth proxy.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: