Skip to content

Conversation

@nakabonne
Copy link
Member

What this PR does / why we need it:
This PR adds

  • Prometheus settings to talk to Alertmanager (it got missed when moving alerting_rules.yml to Configmap)
  • an alerting rule to alert when error rate gets higher

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.08%. This pull request does not change code coverage.

@khanhtc1202
Copy link
Member

/lgtm

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 7850974 into master Aug 17, 2021
@pipecd-bot pipecd-bot deleted the alertmanager-settings branch August 17, 2021 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants