Skip to content

Conversation

@khanhtc1202
Copy link
Member

What this PR does / why we need it:

Add cloud-sql-proxy container as server and ops sidecar to enable connect to GCP Cloud SQL using Cloud SQL Auth proxy.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.08%. This pull request increases coverage by 0.16%.

File Function Base Head Diff
pkg/app/piped/eventwatcher/eventwatcher.go modifyText -- 86.67% +86.67%
pkg/app/piped/eventwatcher/eventwatcher.go watcher.commitFiles 0.00% 0.00% +0.00%
pkg/cache/memorycache/lru_cache.go LRUCache.Get 66.67% 100.00% +33.33%
pkg/config/event_watcher.go EventWatcherEvent.Validate 73.68% 71.43% -2.26%
pkg/regexpool/regexpool.go Pool.Get 87.50% 93.75% +6.25%

@nghialv
Copy link
Member

nghialv commented Aug 17, 2021

/lgtm

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit e29d078 into master Aug 17, 2021
@pipecd-bot pipecd-bot deleted the add-cloud-sql-proxy-sidecar branch August 17, 2021 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants