Skip to content

Conversation

@nghialv
Copy link
Member

@nghialv nghialv commented Jul 12, 2021

What this PR does / why we need it:

Because all workers will exit after the commandHandleTimeout.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Fix bug that all plan-preview commands that come after Piped has been running for 5 minutes are not handled

… running for 5 minutes will be failed with deadline error
@nghialv nghialv changed the title Fix bug that all plan-preview commands that come after Piped has been running for 5 minutes will be failed with deadline error Fix bug that all plan-preview commands that come after Piped has been running for 5 minutes will not be handled Jul 12, 2021
@khanhtc1202
Copy link
Member

Nice catch 👍
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.07%. This pull request decreases coverage by -0.00%.

File Function Base Head Diff
pkg/app/piped/planpreview/handler.go Handler.handleCommand 46.43% 44.83% -1.60%

@pipecd-bot pipecd-bot merged commit 49c812f into master Jul 12, 2021
@pipecd-bot pipecd-bot deleted the plan-preview-bug branch July 12, 2021 13:03
@nghialv
Copy link
Member Author

nghialv commented Jul 12, 2021

/changelog

@pipecd-bot
Copy link
Collaborator

CHANGELOG

@nghialv: Changelog has been generated in response to this comment.

Details

Changelog since v0.11.0

Notable Changes

  • Fix bug that all plan-preview commands that come after Piped has been running for 5 minutes are not handled (#2222)
  • Allow embedding piped-key and ssh-key in Piped config file (#2216)
  • Fix bug that SAVE button at admin account form is not enabled when using the same username (#2209)

Internal Changes

  • Add more logs to plan-preview handler (#2221)
  • Fix validation bug on Piped config (#2219)
  • Let Prometheus not scrape unneeded targets (#2213)
  • Copy SSH key into ssh config dir to use instead of using the given one directly (#2214)
  • Delete unused workflow (#2211)
  • Update OWNERS_ALIASES (#2210)
  • Update Grafana dashboards (#2207)
  • Avoid panic in case of error gathering ops metrics (#2206)
  • Enable ops metrics endpoint (#2203)
  • Expose piped stat metrics at ops metrics endpoint (#2202)
  • Explicitly use string as type for key in cache package (#2200)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants