Skip to content

Fix bug that SAVE button at admin account form is not enabled when using the same username #2209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pipecd-bot merged 2 commits into from
Jul 12, 2021
Merged

Fix bug that SAVE button at admin account form is not enabled when using the same username #2209

pipecd-bot merged 2 commits into from
Jul 12, 2021

Conversation

@nghialv
Copy link
Member

@nghialv nghialv commented Jul 12, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2208

Does this PR introduce a user-facing change?:

Fix bug that SAVE button at admin account form is not enabled when using the same username

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Jul 12, 2021

COVERAGE

Code coverage for golang is 32.07%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Jul 12, 2021

COVERAGE

Code coverage for javascript is 84.50%. This pull request does not change code coverage.

kurochan
kurochan reviewed Jul 12, 2021
View reviewed changes
pkg/app/web/src/components/settings-page/project/components/static-admin-form/index.tsx Outdated
disabled={
formik.isValid === false ||
formik.values.username === currentUsername
formik.values.username === ""
Copy link
Contributor

@kurochan kurochan Jul 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
formik.values.username === ""

I think this line is unnecessary because already validated here.
https://github.com/pipe-cd/pipe/pull/2209/files#diff-0e1fa1872588c27aac2a8c319a43642fd2a980e41ced4719c3d2c96fc00ac622R43

Copy link
Member Author

@nghialv nghialv Jul 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are totally right! Let me remove this line.

Copy link
Member

@nakabonne nakabonne Jul 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure!

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Jul 12, 2021

COVERAGE

Code coverage for golang is 32.07%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Jul 12, 2021

COVERAGE

Code coverage for javascript is 84.50%. This pull request does not change code coverage.

@nakabonne
Copy link
Member

nakabonne commented Jul 12, 2021

Nice
/lgtm

@khanhtc1202
Copy link
Member

khanhtc1202 commented Jul 12, 2021

Nice catch
/approve

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Jul 12, 2021

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit ab29179 into master Jul 12, 2021
@pipecd-bot pipecd-bot deleted the settings branch July 12, 2021 02:29
This was referenced Jul 12, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cakecatz cakecatz Awaiting requested review from cakecatz

@khanhtc1202 khanhtc1202 Awaiting requested review from khanhtc1202

2 more reviewers

@kurochan kurochan kurochan left review comments

@nakabonne nakabonne nakabonne left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved area/web lgtm size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to update only password of admin account

6 participants

@nghialv @pipecd-bot @nakabonne @khanhtc1202 @kurochan