Copy SSH key into ssh config dir to use instead of using the given one directly #2214
Conversation
|
Code coverage for golang is
|
|
Cool |
| f, err := os.CreateTemp(sshDir, "piped-ssh-key-*") | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
Across the docs looks like we should close/remove the opened temp file by ourselves 👀 Should we?
It is the caller's responsibility to remove the file when it is no longer needed.
ref: docs
There was a problem hiding this comment.
You are right. Let me add a TODO to remove the added file.
|
Code coverage for golang is
|
|
Thx 🚀 |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
|
Code coverage for golang is
|
What this PR does / why we need it:
Currently, we are writing an SSH config file to use the given SSH key file directly.
In that way, ssh-agent will consider the directory which contains the given SSH key file as a dedicated directory to deal with key/cert files.
In some cases, users are expecting that the Piped should use the given SSH key file and do nothing with its directory.
So this PR copies the given key into ssh config directory with a random name to use.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: