Skip to content

ci(release): release version bump no longer fails on the pre-commit hook - #26978

Merged
t3dotgg merged 1 commit into
mainfrom
fix/release-commit-skips-hooks
Oct 31, 2026
Merged

t3dotgg merged 1 commit into
mainfrom
fix/release-commit-skips-hooks

Conversation

@t3dotgg

@t3dotgg t3dotgg commented Oct 29, 2026

Copy link
Copy Markdown
Member

The v0.1.5 release failed at "Finalize release". Its git commit ran our pre-commit hook. Since #26167, that hook runs knip when a package.json is staged. The finalize job installs only two workspaces, so knip reported most of the repo as unused and the commit failed (run).

The CI bot commits now use --no-verify. The release step already formats the files it commits. The mobile EAS version bump commits a staged .ts file, so it had the same problem. It gets the same fix.

For v0.1.5, I pushed the version bump to main manually and reran the failed jobs.

🤖 Generated with Claude Code (Claude Opus 5.5)

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 29, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — Release and mobile version-bump commits now bypass the pre-commit hook, including its lint and knip checks. Human review is required to authorize that static-analysis bypass.

No code changes detected at 613e497. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 5.0 KiB 5.0 KiB +6 B (+0.1%) 6.8 KiB ✅
Codex Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.2 KiB 1.3 KiB +6 B (+0.5%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 21.6 KiB 21.6 KiB 0 B (0.0%) 24.4 KiB ✅
Codex Live turn messages 2 2 0 (0.0%) 8 ✅
Claude Total thread wire 5.0 KiB 5.1 KiB +6 B (+0.1%) 6.8 KiB ✅
Claude Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.3 KiB 1.3 KiB +6 B (+0.5%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 21.9 KiB 21.9 KiB 0 B (0.0%) 24.4 KiB ✅
Claude Live turn messages 2 2 0 (0.0%) 8 ✅

Baseline: bf8e132 · PR result: 613e497 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration
Commits

Reviewing files that changed from the base of the PR and between fd0bb50 and 613e497.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 37fbefd and fd0bb50.

Files selected for processing: 2
  • .github/workflows/mobile-eas-production.yml
  • .github/workflows/release.yml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

Walkthrough

Both production workflows now add --no-verify to commits that record version changes.

Changes: Version commit workflows

Layer / File(s) Summary
Skip hooks for version commits
.github/workflows/mobile-eas-production.yml, .github/workflows/release.yml
Both workflows use git commit --no-verify for their version-change commits.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: Minimal · previous review fd0bb

The automated version commits have no remaining merge-blocking risk.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly identifies the release version-bump CI failure caused by the pre-commit hook and matches the changes in both workflows.
Description check Passed The description clearly explains the release failure, the cause, the --no-verify fix, and the related mobile EAS change. It also references the failed run and manual recovery. It does not use the temp…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description clearly explains the release failure, the cause, the --no-verify fix, and the related mobile EAS change. It also references the failed run and manual recovery. It does not use the template headings or provide explicit verification results and approval details, but the core information is present.

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@t3dotgg
t3dotgg force-pushed the fix/release-commit-skips-hooks branch from fd0bb50 to 613e497 Compare October 31, 2026 06:23
@t3dotgg
t3dotgg merged commit b823dcf into main Oct 31, 2026
30 checks passed
@t3dotgg
t3dotgg deleted the fix/release-commit-skips-hooks branch October 31, 2026 06:28
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Oct 31, 2026
**v0.1.6-nightly.20261031.3969** · 55 changes from 33 contributors

## Highlights
Ask questions in side chats without derailing the main thread. See context usage and token counts against the limit.

## Fixes
- HTML render videos can enter full screen (#21378)
- Claude’s context meter shows the correct compaction point (#22654)
- Okta sign-in works in the built-in browser (#22835)
- Installing one agent no longer blocks other agents (#23684)
- File context menu actions respond to clicks (#26579)
- Agents wait for deployments instead of ending turns (#26681)
- Deleted worktree threads recover from detached checkouts (#26758)
- Newer ChatGPT-connected Codex models show reasoning options (#27931)
- Connection credentials no longer appear in request traces (#27986)
- Preview discovery no longer disrupts non-HTTP services (#27893)

<details>
<summary>Full changelog</summary>

## What's Changed
* fix(web): video full-screen buttons work in HTML renders by @punkhop in pingdotgg/t3code#21378
* fix(desktop): compare custom renderer scheme and authority explicitly by @only21mil in pingdotgg/t3code#21445
* fix(web): preview address bar no longer ligates "://" by @sairajchouhan in pingdotgg/t3code#21579
* fix(server): read the smallest iOS simulator text size as small by @only21mil in pingdotgg/t3code#22114
* fix(mobile): relative-time labels keep counting on archive and pull request screens by @only21mil in pingdotgg/t3code#22151
* fix(desktop): stop the macOS Settings tracker when T3 exits by @only21mil in pingdotgg/t3code#22497
* fix(claude): context meter shows where Claude actually auto-compacts by @GitJarno in pingdotgg/t3code#22654
* fix(desktop): browser tabs no longer report loopback access as denied by @afrojun in pingdotgg/t3code#22835
* fix(desktop): explain Hyprland SnapShot activation timeouts by @only21mil in pingdotgg/t3code#23426
* fix(forgejo): reviewer picker lists each assignee once on Forgejo and Gitea by @0pilatos0 in pingdotgg/t3code#23580
* fix(server): release drained terminal output while queue stays busy by @parmartejass in pingdotgg/t3code#23664
* fix(acp-registry): installing one agent no longer blocks other agents by @only21mil in pingdotgg/t3code#23684
* fix(mobile): name iOS environment buttons for VoiceOver by @only21mil in pingdotgg/t3code#23740
* fix(mobile): separate expanded thoughts from the next reply by @shivamhwp in pingdotgg/t3code#25300
* fix(web): chat stays centered while the thread details card fits beside it by @koushikxd in pingdotgg/t3code#25838
* fix(web): match HTML render backgrounds to the dark chat theme by @mydd7 in pingdotgg/t3code#25948
* fix(web): a failed review guide keeps Try again reachable by @NotAnNvidiaFan in pingdotgg/t3code#26073
* fix(mobile): scale compose buttons with text size by @none23 in pingdotgg/t3code#26100
* fix(web): Add Environment dialog reopens on Remote link instead of a stale SSH selection by @Mnigos in pingdotgg/t3code#26160
* fix(web): keep retention controls stable while editing days by @0bkevin in pingdotgg/t3code#26335
* fix(web): prevent permissions label from shrinking on click by @UtkarshUsername in pingdotgg/t3code#26470
* fix(web): add tooltips to boring sidebar actions by @UtkarshUsername in pingdotgg/t3code#26477
* fix(server): searching delegate models no longer drops words found inside the provider name by @MinitJain in pingdotgg/t3code#26502
* fix(server): allow requested browser verification by @Adamulek123 in pingdotgg/t3code#26503
* fix(client-runtime): idle clients stop tracing unchanged platform registrations by @shivamhwp in pingdotgg/t3code#26511
* fix(web): remove gaps between permission options by @Adamulek123 in pingdotgg/t3code#26514
* fix(web): the prompt box follows the interface font size by @dw3105 in pingdotgg/t3code#26559
* perf(server): linked calls reuse sessions while a tool waits by @Adamulek123 in pingdotgg/t3code#26567
* fix(web): file context menu actions respond to pointer clicks by @dbolser in pingdotgg/t3code#26579
* fix(acp): reject models unavailable to the active session by @trahane in pingdotgg/t3code#26623
* fix(mobile): reconnecting threads no longer open on "Failed to connect" by @liamwarfield in pingdotgg/t3code#26643
* fix(web): scheduled task editor shows the destination thread by @shivamhwp in pingdotgg/t3code#26658
* fix(provider): agents wait on a deploy instead of ending the turn by @joshrobertson8 in pingdotgg/t3code#26681
* fix(server): launched threads step down to a runtime mode their provider offers by @henrychu04 in pingdotgg/t3code#26682
* fix(server): deleted worktree threads recover from a detached checkout by @shivamhwp in pingdotgg/t3code#26758
* fix(server): show the database error instead of "Provider turn failed." when event ingestion can't write by @georgenijo in pingdotgg/t3code#26782
* fix(mobile): thread rows show when a title is regenerating by @saphid in pingdotgg/t3code#26835
* fix(web): punctuation after a file chip stays on the chip's line by @kendyl93 in pingdotgg/t3code#26871
* fix(mobile): give Android reply actions 48dp touch targets by @Dwite in pingdotgg/t3code#27020
* perf(server): skip unused projections in thread reads by @Adamulek123 in pingdotgg/t3code#27039
* fix(server): ChatGPT-connected Codex shows reasoning for models newer than its CLI by @t3dotgg in pingdotgg/t3code#27931
* fix(server): keep connection tickets out of request traces by @maria-rcks in pingdotgg/t3code#27904
* fix(web): model settings show "No reasoning" instead of labeling every model by @t3dotgg in pingdotgg/t3code#27891
* fix(server): hide rolling resets for untouched Antigravity quotas by @SouthCarpet in pingdotgg/t3code#23558
* fix(mobile): disabled iOS header controls now show as disabled by @only21mil in pingdotgg/t3code#24088
* fix(web,mobile): Luau files are syntax highlighted in diffs by @Yuruzuu in pingdotgg/t3code#25865
* perf(web): the pull request timeline mounts only the events near the viewport by @juliusmarminge in pingdotgg/t3code#27795
* perf(web): pull request comments reuse their markdown parse by @juliusmarminge in pingdotgg/t3code#27808
* fix(observability): redact credential URL params in spans and type them as Redacted by @juliusmarminge in pingdotgg/t3code#27986
* fix(web): back-to-back messages stack tight with joined corners by @maria-rcks in pingdotgg/t3code#27978
* feat(web): context meter fills up and shows tokens against the limit by @t3dotgg in pingdotgg/t3code#27892
* fix(server): preview discovery stops sending HTTP and TLS to agent-started ports by @t3dotgg in pingdotgg/t3code#27893
* ci(release): release version bump no longer fails on the pre-commit hook by @t3dotgg in pingdotgg/t3code#26978
* feat: side chats beside the main thread by @t3dotgg in pingdotgg/t3code#26901
* fix(desktop): name the running app in Windows installer prompts by @Yash-Singh1 in pingdotgg/t3code#27886

## New Contributors
* @punkhop made their first contribution in pingdotgg/t3code#21378
* @GitJarno made their first contribution in pingdotgg/t3code#22654
* @afrojun made their first contribution in pingdotgg/t3code#22835
* @mydd7 made their first contribution in pingdotgg/t3code#25948
* @NotAnNvidiaFan made their first contribution in pingdotgg/t3code#26073
* @MinitJain made their first contribution in pingdotgg/t3code#26502
* @dbolser made their first contribution in pingdotgg/t3code#26579
* @trahane made their first contribution in pingdotgg/t3code#26623
* @liamwarfield made their first contribution in pingdotgg/t3code#26643
* @georgenijo made their first contribution in pingdotgg/t3code#26782
* @kendyl93 made their first contribution in pingdotgg/t3code#26871
* @Dwite made their first contribution in pingdotgg/t3code#27020

**Full Changelog**: pingdotgg/t3code@v0.1.6-nightly.20261031.3956...v0.1.6-nightly.20261031.3969

</details>


Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.1.6-nightly.20261031.3969
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant