Repository navigation
refactor(web): move project script editing out of ChatView - #20401
Merged
juliusmarminge merged 1 commit intoOct 17, 2026
Merged
juliusmarminge merged 1 commit into
juliusmarminge merged 1 commit into
Conversation
juliusmarminge
added this pull request to stack #20165
October 16, 2026 22:28
Contributor
Thread transfer impact
This comment will update automatically after the next completed run. |
juliusmarminge
force-pushed
the
chatview-split/project-scripts
branch
from
October 16, 2026 23:27
7f957e9 to
e60266a
Compare
This was referenced Oct 16, 2026
Merged
juliusmarminge
force-pushed
the
chatview-split/project-scripts
branch
from
October 17, 2026 00:02
e60266a to
bacc457
Compare
juliusmarminge
force-pushed
the
chatview-split/project-scripts
branch
from
October 17, 2026 00:11
bacc457 to
dd9e683
Compare
juliusmarminge
force-pushed
the
chatview-split/project-scripts
branch
2 times, most recently
from
October 17, 2026 00:33
1fa186b to
6ac2ee5
Compare
Adding, editing and deleting a project's scripts (and reconciling their keyboard shortcuts) was 220 lines in ChatView plus three atom commands only it used. useProjectScriptEditing owns them and returns stable handlers for the scripts control. It reads the environment's server config from the atom registry at call time instead of the render's environment map, so the shortcut it replaces is the one currently stored. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
juliusmarminge
force-pushed
the
chatview-split/project-scripts
branch
from
October 17, 2026 00:39
6ac2ee5 to
b3db3c0
Compare
juliusmarminge
marked this pull request as ready for review
October 17, 2026 00:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChatView carried about 220 lines for adding, editing and deleting a project's scripts, plus three atom commands that nothing else in ChatView used: update settings, upsert keybinding and remove keybinding. That code also reconciles each script's keyboard shortcut.
chat/useProjectScriptEditing.tsnow owns that code and returns stablesaveProjectScript/updateProjectScript/deleteProjectScripthandlers for the scripts control. The logic moved over unchanged, with one exception: the environment's server config, used for the keybindings to replace and the project-settings-override capability, is read from the atom registry when the handler runs, not from the render's environment map. The shortcut it replaces is therefore the one currently stored. Running scripts stays in ChatView because it drives the terminal drawer.The hook is on the compile-required list. ChatView drops from 9,340 to 9,110 lines.
Tests:
projectScripts,reactCompiledFiles(36 pass).Stack progress
Measured with the native React Compiler (
oxc-transform-react) on each layer'sChatView.tsx. "Crashes" means it hit an internal codegen error and left ChatView uncompiled; "skips" means it reported reasons it could not compile it. Strict files must compile with no bailouts, no manual memoization and no effect-rule violations; lint andreactCompiledFiles.test.tsenforce it.🤖 Generated with Claude Code (Claude Opus 5.5)