Repository navigation
fix(web): stop crashing the native React Compiler on ChatView - #20340
Conversation
github-actions
Bot
added
the
vouch:trusted
juliusmarminge
added
the
macroscope-review
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a small, tested extraction of an existing pure ChatView predicate to unblock compiler analysis. The production behavior remains equivalent, with no new capability, product-default change, deployment change, or static-analysis suppression. No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check |  |
The description explains the problem and the code change, but it does not provide the required Scope and approval section or focused Verification details with test commands and observed results. | Add a Scope and approval section with the related issue, maintainer approval, or justification for this focused fix. Add a Verification section that lists the tests or manual checks run, their observed results, and any checks that were not … |
-
Check name Status Explanation Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Title check The title clearly identifies the main change: preventing the native React Compiler from crashing on ChatView.
Full details: Description check
-
Resolution
Add a Scope and approval section with the related issue, maintainer approval, or justification for this focused fix. Add a Verification section that lists the tests or manual checks run, their observed results, and any checks that were not run.
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
`Math.max(...)` inside ChatView's woke-visibility memo hit an internal codegen invariant in oxc's React Compiler, so it abandoned the whole component after spending ~15s on it, and never reported the real reasons ChatView can't compile. The check is now the pure isThreadWokeUnseen in ChatView.logic, with tests. The compiler now reaches ChatView's real bailouts (ref reads during render, try/finally in handlers, memo mismatches), which the next layers fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
94fb2f7 to
30f3439
Compare
Brings in upstream through pingdotgg#20797 (144aae4). - React Compiler cleanup (pingdotgg#20340 and ~300 perf/refactor PRs): the web components Cody patches were rewritten without manual memoization. Cody's worktree base selection, scheduled task thread picker, Tailscale SSH remote open login, and WSL tailnet pairing links were reapplied onto the new code, also without manual memoization. - Adapted: ChatView now keeps the chosen worktree base per thread, like upstream's new per-thread branch and env mode overrides, instead of clearing it from effects. - AutoInstallUpdatesRow: dropped useCallback for the new no-manual-memo lint rule. - Worktree handoff MCP: the custom path option is gone, so Cody's base-ref test no longer passes one. - Git runs with safe.bareRepository=explicit (pingdotgg#20440): Cody's worktree base test now names the bare repo with --git-dir. - fetchRemoteTrackingBranch: kept Cody's non-interactive env with upstream's `--` before the remote name. - Superseded: none.
1 participant
Part of the ChatView split so the React Compiler can compile it.
Problem. ChatView never compiled, and the compiler never said why. The native React Compiler hit an internal codegen error on one
Math.max(...)call in the "woke from snooze" check, abandoned the whole component after spending ~15s on it, and reported only that crash. None of the earlier layers could change that on their own.Fix. The check is now
isThreadWokeUnseeninChatView.logic, with tests. With the crash gone, the compiler reaches ChatView's real problems and lists them, which the next layer fixes.try/finallyorthrowintryuseMemodeps it can't preserveStack progress
Measured with the native React Compiler (
oxc-transform-react) on each layer'sChatView.tsx. "Crashes" means it hit an internal codegen error and left ChatView uncompiled; "skips" means it reported reasons it could not compile it. Strict files must compile with no bailouts, no manual memoization and no effect-rule violations; lint andreactCompiledFiles.test.tsenforce it.🤖 Generated with Claude Code (Claude Opus 5.5)