fix(desktop): restore layout control hit targets - #10673
Conversation
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a focused desktop UI bug fix confined to titlebar drag-region hit testing. It preserves explicit no-drag controls and introduces no schema, infrastructure, security, billing, or static-analysis changes. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe Electron drag-region child reset now uses ChangesDrag-region behavior
Priority: ➖ Normal — Impact reflects medium issue severity. Estimated code review effort: 2 (Simple) | ~5 minutes Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to Desktop titlebar children regain normal pointer interaction while titlebar dragging and explicit drag controls remain preserved. No current merge-blocking risk is identified. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
Dismissing prior approval to re-evaluate f7deb75
Dismissing prior approval to re-evaluate 7862a3c
## What's Changed * fix(web): open proactive panels when entering threads by @maria-rcks in pingdotgg/t3code#10610 * fix(native): wait for the KDE feedback test listener by @juliusmarminge in pingdotgg/t3code#10645 * fix(desktop): resolve local media linked from remote threads by @maria-rcks in pingdotgg/t3code#10619 * fix(web): add bottom padding to project actions header by @flamboh in pingdotgg/t3code#10634 * fix(web): update machines together in auto balance by @maria-rcks in pingdotgg/t3code#10596 * fix(preview): transfer recordings to the agent environment by @maria-rcks in pingdotgg/t3code#10572 * fix(web): navigate markdown images as galleries by @maria-rcks in pingdotgg/t3code#10625 * chore: upgrade to TypeScript 7.0.2 by @juliusmarminge in pingdotgg/t3code#10663 * fix: hide email-bearing account labels in usage limits by @juliusmarminge in pingdotgg/t3code#10668 * fix(web): keep scroll-to-end button close to composer by @Bil0000 in pingdotgg/t3code#10543 * chore(deps): upgrade Effect to rc.112 and Alchemy to beta.76 by @juliusmarminge in pingdotgg/t3code#10652 * chore(refs): sync Effect reference to rc.112 by @juliusmarminge in pingdotgg/t3code#10653 * chore(refs): sync Alchemy reference to beta.76 by @juliusmarminge in pingdotgg/t3code#10654 * fix: generate thread titles with the selected model across connections by @Bil0000 in pingdotgg/t3code#10526 * fix(desktop): enable context menus in the browser by @juliusmarminge in pingdotgg/t3code#10670 * fix(desktop): stop generating declarations during bundling by @juliusmarminge in pingdotgg/t3code#10679 * fix(desktop): restore layout control hit targets by @juliusmarminge in pingdotgg/t3code#10673 **Full Changelog**: pingdotgg/t3code@v0.0.41-nightly.20260908.1377...v0.0.41-nightly.20260908.1387 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.41-nightly.20260908.1387
Electron 44 makes
app-regioninherit into header children. Later header rectangles cover the fixed layout buttons, leaving only their thin edges clickable.Reset direct children of each drag region with
-webkit-app-region: initial. This stops inherited rectangles from covering controls while preserving the parent titlebar's drag area. Explicitnoneis unsuitable here: Chromium converts it tono-drag, which removes the children's area from the draggable titlebar. The base-layer rule preserves explicit drag/no-drag utilities.Validation:
nonecomputes tono-drag, whileinitialcomputes to the neutralnonestate. The header retainsdragand its button retainsno-drag.Closes #10661
Note
Fix drag-region hit targets by resetting
-webkit-app-regionfor direct childrenAdds a base-layer CSS rule in index.css that resets
-webkit-app-regionto its initial value for direct children of.drag-region. Existing unlayered selectors for buttons, inputs, textareas, selects, and links still mark those controls asno-dragand take precedence over the layered reset. This restores correct click behavior for layout controls inside frameless titlebar drag regions.Macroscope summarized 7862a3c.
Summary by CodeRabbit
Model: GPT-6. Harness: Codex.