Skip to content

fix(desktop): keep sidebar artwork out of the drag region - #10680

Closed
Gigioxx wants to merge 1 commit into
pingdotgg:mainfrom
Gigioxx:fix/sidebar-art-drag-10661
Closed

fix(desktop): keep sidebar artwork out of the drag region#10680
Gigioxx wants to merge 1 commit into
pingdotgg:mainfrom
Gigioxx:fix/sidebar-art-drag-10661

Conversation

@Gigioxx

@Gigioxx Gigioxx commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

What Changed

Reset -webkit-app-region to initial on the shared sidebar artwork. This prevents the artwork from inheriting the header's native drag region.

Why

The 80px artwork extends below the 52px header and covers Search and New thread. Electron inherits app-region: drag through the artwork, so native pointer events never reach those controls, while the keyboard shortcut still works. pointer-events: none does not exclude a native drag region.

Use initial because Electron maps an explicit none to no-drag, which would cancel dragging across the overlapping header. The reset keeps the header at drag and the artwork at the initial none value. Development and nightly artwork share this fix.

Fixes #10661.

Verified with Electron 44.1.0 on macOS using isolated state copied from an existing profile: native pen clicks open the project picker, Search accepts typing, and repeated clicks work after dismissal. Restoring the original inherited style reproduces the blocked pen with no pointer events; Cmd+N still opens the picker. Linux/Hyprland and Shift-click were not exercised. Web build, scoped formatting, and git diff --check pass. No JavaScript, provider, or contract changes.

UI Changes

Cropped to omit project paths and thread content. Before restores the original inherited style; after uses the compiled fix.

Before: native click ignored After: native click opens picker
Before After

Native click interaction recording

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Model: GPT-6. Harness: Codex.

Note

Reset -webkit-app-region on sidebar-stage-backdrop utility

The sidebar stage artwork was inheriting the titlebar's native drag region, making it uninteractable. Adds a WebKit app-region reset to the sidebar-stage-backdrop CSS utility in index.css so those elements use the initial app-region value instead.

📊 Macroscope summarized 994a6cd. 1 file reviewed, 1 issue evaluated, 1 issue filtered, 0 comments posted

🗂️ Filtered Issues

apps/web/src/index.css — 0 comments posted, 1 evaluated, 1 filtered
  • line 407: -webkit-app-region: initial only resets the artwork to the property's initial value; it does not create the no-drag exclusion Electron requires. The backdrop is a child of the .drag-region header and overlaps controls below the 52px header, so the ancestor's rectangular draggable region still covers that area and native pointer events remain suppressed. Electron documents app-region: no-drag as the operation that excludes an overlapping rectangle and reenables pointer events. [ Out of scope (triage) ]

Summary by CodeRabbit

  • Bug Fixes
    • Prevented stage-channel artwork extending below the title bar from being treated as a window drag area.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 8, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 994a6cd

Macroscope's review found this PR approvable — This is a one-file, two-line desktop CSS fix that confines the sidebar artwork's native drag-region behavior without changing application logic or contracts. Its runtime effect is limited to restoring pointer interaction in the affected sidebar area.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: a7e8b68f-a9df-438e-897d-aa9187c884ac

📥 Commits

Reviewing files that changed from the base of the PR and between b5f7fa0 and 994a6cd.

📒 Files selected for processing (1)
  • apps/web/src/index.css

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The sidebar-stage-backdrop utility now resets -webkit-app-region to prevent artwork below the titlebar from inheriting the native window drag region.

Changes

Sidebar backdrop interaction

Layer / File(s) Summary
Reset backdrop drag region
apps/web/src/index.css
The sidebar-stage-backdrop utility sets -webkit-app-region: initial for artwork extending below the titlebar.

Priority: ➖ Normal — Impact reflects medium issue severity.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to 994a6

Sidebar artwork no longer captures native drag behavior below the titlebar, allowing the underlying New thread and Search controls to receive pointer events while retaining header dragging. The focused CSS change is ready to merge.

Suggested reviewers: juliusmarminge, maria-rcks, t3dotgg

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Linked Issues check ❓ Inconclusive The change directly targets issue #10661, but the issue reports a Linux/Wayland failure and requires normal and Shift-click behavior. The PR verifies only macOS, does not verify Linux or Shift-click, … Validate the fix on Linux/Wayland with normal clicks, hover, and Shift-click. Confirm that the artwork no longer suppresses pointer events while header dragging remains functional. If initial does not provide the required exclusion, use a…
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the CSS fix that keeps sidebar artwork outside the native drag region.
Description check ✅ Passed The description includes the change, reason, UI evidence, validation details, scope, and completed checklist items. It also documents untested Linux and Shift-click cases.
Out of Scope Changes check ✅ Passed The code change is limited to the shared sidebar artwork CSS utility and directly supports issue #10661. The additional description evidence and validation details do not introduce out-of-scope code c…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Linked Issues check

Explanation

The change directly targets issue #10661, but the issue reports a Linux/Wayland failure and requires normal and Shift-click behavior. The PR verifies only macOS, does not verify Linux or Shift-click, and the review note questions whether initial excludes the inherited draggable region.

Resolution

Validate the fix on Linux/Wayland with normal clicks, hover, and Shift-click. Confirm that the artwork no longer suppresses pointer events while header dragging remains functional. If initial does not provide the required exclusion, use an implementation that explicitly creates the correct non-draggable region.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@juliusmarminge

Copy link
Copy Markdown
Member

Superseded: #10661 was fixed and closed by #10673. Closing this PR as leftover hygiene.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Sidebar New thread button ignores hover and clicks on Linux nightly

2 participants