Skip to content

fix(web): add bottom padding to project actions header - #10634

Merged
maria-rcks merged 1 commit into
pingdotgg:mainfrom
flamboh:t3code/fix-actions-panel-spacing
Sep 8, 2026
Merged

fix(web): add bottom padding to project actions header#10634
maria-rcks merged 1 commit into
pingdotgg:mainfrom
flamboh:t3code/fix-actions-panel-spacing

Conversation

@flamboh

@flamboh flamboh commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Note

🤖 GPT-6 on behalf of Oliver

ELI5

Give the project Actions header breathing room above the divider.

Problem

The header only had top padding. Its description touched the divider on desktop, and the action buttons touched it at narrow widths.

Fix

Change pt-4 to py-4, preserving 16px above the header and adding 16px below it. This shared web/desktop layout applies to inherited and overridden project actions.

Validation: web typecheck and targeted formatting passed. Targeted lint reports one existing memo-dependency warning at line 696. Code review found no actionable issues. Used test-t3-app with isolated state to verify empty layouts at 1440px and 390px, plus adding and resetting an action at 390px without horizontal overflow. Chromium resource failures required bundled dev mode and prevented completing the populated desktop check. Native clients were not run.

UI Changes

Before

Desktop before

Narrow before

After

Desktop after

Narrow after

Populated narrow layout

Populated narrow after

Made with GPT-6 in Codex.

Note

Add bottom padding to Actions section in ProjectSettingsPanel

Updates the Actions container in ProjectSettingsPanel.tsx to use equal vertical padding instead of top padding only. Existing top padding and responsive layout classes are preserved.

Macroscope summarized 242a64a.

Summary by CodeRabbit

  • Style
    • Adjusted spacing around the Actions section header in project settings for improved visual consistency.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 8, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 242a64a

Macroscope's review found this PR approvable — This one-line change only adds bottom padding to the existing project actions header, producing a contained visual layout improvement without changing behavior, data flow, or application defaults.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 8b0cbb98-35f7-4f91-96df-6b6dc7fcf550

📥 Commits

Reviewing files that changed from the base of the PR and between 8588d7f and 242a64a.

📒 Files selected for processing (1)
  • apps/web/src/components/settings/ProjectSettingsPanel.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The Actions section header in the project settings panel changes from top-only padding to equal vertical padding.

Changes

Project settings spacing

Layer / File(s) Summary
Actions header spacing
apps/web/src/components/settings/ProjectSettingsPanel.tsx
The Actions section header changes from px-3 pt-4 to px-3 py-4, adding bottom padding without changing behavior.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 242a6

The Actions header now includes bottom padding so its description and controls are visually separated from the divider. This is a contained presentation-only change with no remaining merge-readiness risk.

Suggested reviewers: maria-rcks, t3dotgg, juliusmarminge

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding bottom padding to the project Actions header.
Description check ✅ Passed The description clearly explains the problem, fix, validation, limitations, and UI changes with before-and-after screenshots. It does not use the template headings exactly and omits the checklist, but…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@maria-rcks
maria-rcks merged commit b7c002f into pingdotgg:main Sep 8, 2026
22 checks passed
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 8, 2026
## What's Changed
* fix(web): open proactive panels when entering threads by @maria-rcks in pingdotgg/t3code#10610
* fix(native): wait for the KDE feedback test listener by @juliusmarminge in pingdotgg/t3code#10645
* fix(desktop): resolve local media linked from remote threads by @maria-rcks in pingdotgg/t3code#10619
* fix(web): add bottom padding to project actions header by @flamboh in pingdotgg/t3code#10634
* fix(web): update machines together in auto balance by @maria-rcks in pingdotgg/t3code#10596
* fix(preview): transfer recordings to the agent environment by @maria-rcks in pingdotgg/t3code#10572
* fix(web): navigate markdown images as galleries by @maria-rcks in pingdotgg/t3code#10625
* chore: upgrade to TypeScript 7.0.2 by @juliusmarminge in pingdotgg/t3code#10663
* fix: hide email-bearing account labels in usage limits by @juliusmarminge in pingdotgg/t3code#10668
* fix(web): keep scroll-to-end button close to composer by @Bil0000 in pingdotgg/t3code#10543
* chore(deps): upgrade Effect to rc.112 and Alchemy to beta.76 by @juliusmarminge in pingdotgg/t3code#10652
* chore(refs): sync Effect reference to rc.112 by @juliusmarminge in pingdotgg/t3code#10653
* chore(refs): sync Alchemy reference to beta.76 by @juliusmarminge in pingdotgg/t3code#10654
* fix: generate thread titles with the selected model across connections by @Bil0000 in pingdotgg/t3code#10526
* fix(desktop): enable context menus in the browser by @juliusmarminge in pingdotgg/t3code#10670
* fix(desktop): stop generating declarations during bundling by @juliusmarminge in pingdotgg/t3code#10679
* fix(desktop): restore layout control hit targets by @juliusmarminge in pingdotgg/t3code#10673


**Full Changelog**: pingdotgg/t3code@v0.0.41-nightly.20260908.1377...v0.0.41-nightly.20260908.1387

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.41-nightly.20260908.1387
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants