Skip to content

ingest: retry failed regions when batch scatter regions (#61722)#62288

Merged
ti-chi-bot[bot] merged 16 commits intopingcap:release-8.5from
ti-chi-bot:cherry-pick-61722-to-release-8.5
Jul 16, 2025
Merged

ingest: retry failed regions when batch scatter regions (#61722)#62288
ti-chi-bot[bot] merged 16 commits intopingcap:release-8.5from
ti-chi-bot:cherry-pick-61722-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #61722

What problem does this PR solve?

Issue Number: close #60077

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Jul 8, 2025
@ti-chi-bot
Copy link
Member Author

@GMHDBJD This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@GMHDBJD GMHDBJD force-pushed the cherry-pick-61722-to-release-8.5 branch from 7099436 to 69e0765 Compare July 11, 2025 07:39
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 11, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 11, 2025
@tangenta tangenta removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 11, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 11, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-07-11 07:40:20.066295907 +0000 UTC m=+2244672.789474891: ☑️ agreed by GMHDBJD.
  • 2025-07-11 07:44:26.03899235 +0000 UTC m=+2244918.762171331: ☑️ agreed by tangenta.

@codecov
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

Attention: Patch coverage is 85.29412% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@1207f79). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #62288   +/-   ##
================================================
  Coverage               ?   57.6476%           
================================================
  Files                  ?       1779           
  Lines                  ?     631157           
  Branches               ?          0           
================================================
  Hits                   ?     363847           
  Misses                 ?     242748           
  Partials               ?      24562           
Flag Coverage Δ
integration 38.1878% <43.3333%> (?)
unit 72.7314% <85.2941%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9278% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 63.3722% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GMHDBJD
Copy link
Contributor

GMHDBJD commented Jul 11, 2025

/retest

@ti-chi-bot ti-chi-bot bot added the approved label Jul 11, 2025
@GMHDBJD
Copy link
Contributor

GMHDBJD commented Jul 14, 2025

/retest

1 similar comment
@GMHDBJD
Copy link
Contributor

GMHDBJD commented Jul 14, 2025

/retest

@GMHDBJD
Copy link
Contributor

GMHDBJD commented Jul 14, 2025

/retest

@Benjamin2037
Copy link
Collaborator

/retest

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 14, 2025
@Benjamin2037
Copy link
Collaborator

/retest

@tangenta tangenta force-pushed the cherry-pick-61722-to-release-8.5 branch from d5375f7 to 27e744d Compare July 15, 2025 15:47
@ti-chi-bot ti-chi-bot bot added component/dumpling This is related to Dumpling of TiDB. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved labels Jul 15, 2025
@GMHDBJD GMHDBJD force-pushed the cherry-pick-61722-to-release-8.5 branch from 27e744d to d5375f7 Compare July 15, 2025 15:54
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 15, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, tangenta, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 15, 2025
GMHDBJD and others added 5 commits July 16, 2025 09:53
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 16, 2025

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test-ddlv1 27e744d link true /test pull-unit-test-ddlv1

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

This reverts commit cf3a4d1.

Signed-off-by: Juncen Yu <yujuncen@pingcap.com>
@ti-chi-bot ti-chi-bot bot merged commit 62f5427 into pingcap:release-8.5 Jul 16, 2025
19 checks passed
JQWong7 pushed a commit to stevenayu/tidb that referenced this pull request Jul 30, 2025
JQWong7 added a commit to stevenayu/tidb that referenced this pull request Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. component/dumpling This is related to Dumpling of TiDB. lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants