Skip to content

lightning: added retry times and two new retry reasons | tidb-test=release-8.1.2#60839

Merged
ti-chi-bot[bot] merged 3 commits intopingcap:feature/release-8.1-gsort-testfrom
GMHDBJD:fixPDRetry
Apr 27, 2025
Merged

lightning: added retry times and two new retry reasons | tidb-test=release-8.1.2#60839
ti-chi-bot[bot] merged 3 commits intopingcap:feature/release-8.1-gsort-testfrom
GMHDBJD:fixPDRetry

Conversation

@GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Apr 25, 2025

What problem does this PR solve?

Issue Number: ref #60077

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 25, 2025
@tiprow
Copy link

tiprow bot commented Apr 25, 2025

Hi @GMHDBJD. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@GMHDBJD GMHDBJD changed the title lightning: added retry times and two new retry reasons lightning: added retry times and two new retry reasons | tidb-test=release-8.1.2 Apr 25, 2025
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 25, 2025
@codecov
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (feature/release-8.1-gsort-test@c37aaeb). Learn more about missing BASE report.

Additional details and impacted files
@@                         Coverage Diff                         @@
##             feature/release-8.1-gsort-test     #60839   +/-   ##
===================================================================
  Coverage                                  ?   71.0812%           
===================================================================
  Files                                     ?       1473           
  Lines                                     ?     425586           
  Branches                                  ?          0           
===================================================================
  Hits                                      ?     302512           
  Misses                                    ?     102481           
  Partials                                  ?      20593           
Flag Coverage Δ
unit 71.0812% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.5701% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 25, 2025
@D3Hunter D3Hunter requested a review from lance6716 April 25, 2025 09:42
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Apr 25, 2025

/retest

@tiprow
Copy link

tiprow bot commented Apr 25, 2025

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: D3Hunter, lance6716
Once this PR has been reviewed and has the lgtm label, please assign bornchanger for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 27, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 27, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-25 09:42:13.63271536 +0000 UTC m=+607877.444505741: ☑️ agreed by D3Hunter.
  • 2025-04-27 01:54:57.761385377 +0000 UTC m=+752641.573175754: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit 2a60895 into pingcap:feature/release-8.1-gsort-test Apr 27, 2025
18 checks passed
GMHDBJD added a commit to GMHDBJD/tidb that referenced this pull request Jun 16, 2025
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jun 27, 2025

/cherry-pick release-8.1

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jun 27, 2025

/cherry-pick release-8.5

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jun 27, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

@GMHDBJD: new pull request created to branch release-8.1: #62063.
But this PR has conflicts, please resolve them!

Details

In response to this:

/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@GMHDBJD: new pull request created to branch release-8.5: #62064.

Details

In response to this:

/cherry-pick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants