importinto: retry scatter regions when finished percentage is not 100 | tidb-test=release-8.1.2 by GMHDBJD · Pull Request #60315 · pingcap/tidb

GMHDBJD · 2025-03-28T08:07:17Z

What problem does this PR solve?

Issue Number: ref #60077

Problem Summary:

What changed and how does it work?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

tiprow · 2025-03-28T08:07:33Z

Hi @GMHDBJD. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

…ntage is not 100

GMHDBJD · 2025-03-28T08:25:58Z

/retest

tiprow · 2025-03-28T08:26:22Z

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2025-03-28T08:41:22Z

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature/release-8.1-gsort-test@54907f8). Learn more about missing BASE report.

Additional details and impacted files

@@                         Coverage Diff                         @@
##             feature/release-8.1-gsort-test     #60315   +/-   ##
===================================================================
  Coverage                                  ?   71.4229%           
===================================================================
  Files                                     ?       1499           
  Lines                                     ?     432697           
  Branches                                  ?          0           
===================================================================
  Hits                                      ?     309045           
  Misses                                    ?     102368           
  Partials                                  ?      21284

Flag	Coverage Δ
unit	`71.2285% <76.4705%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.9656% <0.0000%> (?)`
parser	`∅ <0.0000%> (?)`
br	`41.5501% <0.0000%> (?)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…' into addFailedRegionIDPick

Benjamin2037

LGTM

…' into addFailedRegionIDPick

D3Hunter · 2025-04-02T06:17:38Z

br/pkg/restore/split/client.go

+		// but the old version of PD will only return the FinishedPercentage.
+		// so we need to retry the regions one by one.
+		if isUnsupportedError(err) || berrors.ErrPDRegionsNotFullyScatter.Equal(err) {
 			log.Warn("batch scatter isn't supported, rollback to old method", logutil.ShortError(err))


please refine the log message too

ti-chi-bot · 2025-04-02T06:29:20Z

[LGTM Timeline notifier]

Timeline:

2025-03-31 09:27:09.521629582 +0000 UTC m=+1470923.205865680: ☑️ agreed by Benjamin2037.
2025-04-02 06:29:19.112885139 +0000 UTC m=+1633052.797121235: ☑️ agreed by D3Hunter.

D3Hunter · 2025-04-02T08:29:38Z

/retest

tiprow · 2025-04-02T08:30:00Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot · 2025-04-02T08:44:21Z

@GMHDBJD: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-unit-test-ddlv1	`9047ed5`	link	true	`/test pull-unit-test-ddlv1`
pull-integration-e2e-test	`9047ed5`	link	true	`/test pull-integration-e2e-test`
pull-integration-ddl-test	`9047ed5`	link	false	`/test pull-integration-ddl-test`
pull-lightning-integration-test	`9047ed5`	link	false	`/test pull-lightning-integration-test`
pull-br-integration-test	`9047ed5`	link	false	`/test pull-br-integration-test`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

D3Hunter · 2025-04-02T08:46:00Z

/retest

tiprow · 2025-04-02T08:46:24Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot · 2025-04-02T10:07:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, D3Hunter, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Benjamin2037,D3Hunter,YuJuncen]
~~br/OWNERS~~ [YuJuncen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…pingcap#60315) ref pingcap#60077

ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 28, 2025

GMHDBJD changed the title ~~importinot: retry scatter regions when scatter regions finished perce…~~ importinot: retry scatter regions when finished percentage is not 100 Mar 28, 2025

GMHDBJD changed the title ~~importinot: retry scatter regions when finished percentage is not 100~~ importinto: retry scatter regions when finished percentage is not 100 Mar 28, 2025

importinot: retry scatter regions when scatter regions finished perce…

9047ed5

…ntage is not 100

GMHDBJD force-pushed the addFailedRegionIDPick branch from ebc8814 to 9047ed5 Compare March 28, 2025 08:11

ti-chi-bot bot added component/dumpling This is related to Dumpling of TiDB. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 28, 2025

GMHDBJD changed the base branch from master to feature/release-8.1-gsort-test March 28, 2025 08:12

ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 28, 2025

GMHDBJD changed the title ~~importinto: retry scatter regions when finished percentage is not 100~~ importinto: retry scatter regions when finished percentage is not 100 | tidb-test=release-8.1.2 Mar 28, 2025

GMHDBJD added 4 commits March 31, 2025 13:15

Merge remote-tracking branch 'upstream/feature/release-8.1-gsort-test…

ef7c045

…' into addFailedRegionIDPick

make errdoc

800e626

add ut

560e849

make bazel

899d9d9

Benjamin2037 approved these changes Mar 31, 2025

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 31, 2025

Merge remote-tracking branch 'upstream/feature/release-8.1-gsort-test…

9d67683

…' into addFailedRegionIDPick

D3Hunter removed the do-not-merge/needs-linked-issue label Apr 2, 2025

D3Hunter reviewed Apr 2, 2025

View reviewed changes

address comment

57f2db2

D3Hunter approved these changes Apr 2, 2025

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 2, 2025

YuJuncen approved these changes Apr 2, 2025

View reviewed changes

ti-chi-bot bot added the approved label Apr 2, 2025

ti-chi-bot bot merged commit 0162dfa into pingcap:feature/release-8.1-gsort-test Apr 2, 2025
18 checks passed

GMHDBJD added a commit to ti-chi-bot/tidb that referenced this pull request Jul 11, 2025

importinto: retry scatter regions when finished percentage is not 100 (…

d4d2f06

…pingcap#60315) ref pingcap#60077

GMHDBJD added a commit to ti-chi-bot/tidb that referenced this pull request Jul 11, 2025

importinto: retry scatter regions when finished percentage is not 100 (…

8d595de

…pingcap#60315) ref pingcap#60077

GMHDBJD added a commit to ti-chi-bot/tidb that referenced this pull request Jul 16, 2025

importinto: retry scatter regions when finished percentage is not 100 (…

1fd1da5

…pingcap#60315) ref pingcap#60077

Leavrth pushed a commit to Leavrth/tidb that referenced this pull request Dec 5, 2025

importinto: retry scatter regions when finished percentage is not 100 (…

a7c35f3

…pingcap#60315) ref pingcap#60077

Leavrth mentioned this pull request Dec 5, 2025

region scatter client: retry scatter regions when finished percentage is not 100. #64884

Merged

13 tasks

This was referenced Dec 5, 2025

region scatter client: retry scatter regions when finished percentage is not 100. (#64884) #64885

Open

region scatter client: retry scatter regions when finished percentage is not 100. (#64884) #65000

Closed

Conversation

GMHDBJD commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Uh oh!

tiprow bot commented Mar 28, 2025

Uh oh!

GMHDBJD commented Mar 28, 2025

Uh oh!

tiprow bot commented Mar 28, 2025

Uh oh!

codecov bot commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Benjamin2037 left a comment

Choose a reason for hiding this comment

Uh oh!

D3Hunter Apr 2, 2025

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot bot commented Apr 2, 2025

[LGTM Timeline notifier]

Uh oh!

D3Hunter commented Apr 2, 2025

Uh oh!

tiprow bot commented Apr 2, 2025

Uh oh!

ti-chi-bot bot commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

D3Hunter commented Apr 2, 2025

Uh oh!

tiprow bot commented Apr 2, 2025

Uh oh!

ti-chi-bot bot commented Apr 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

GMHDBJD commented Mar 28, 2025 •

edited

Loading

codecov bot commented Mar 28, 2025 •

edited

Loading

ti-chi-bot bot commented Apr 2, 2025 •

edited

Loading