Skip to content

lightning: added retry times and two new retry reasons (#60839)#62064

Closed
ti-chi-bot wants to merge 4 commits intopingcap:release-8.5from
ti-chi-bot:cherry-pick-60839-to-release-8.5
Closed

lightning: added retry times and two new retry reasons (#60839)#62064
ti-chi-bot wants to merge 4 commits intopingcap:release-8.5from
ti-chi-bot:cherry-pick-60839-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #60839

What problem does this PR solve?

Issue Number: ref #60077

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Jun 27, 2025
@GMHDBJD GMHDBJD changed the title lightning: added retry times and two new retry reasons | tidb-test=release-8.1.2 (#60839) lightning: added retry times and two new retry reasons (#60839) Jun 27, 2025
@codecov
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@310cdcc). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #62064   +/-   ##
================================================
  Coverage               ?   57.9759%           
================================================
  Files                  ?       1771           
  Lines                  ?     636457           
  Branches               ?          0           
================================================
  Hits                   ?     368992           
  Misses                 ?     242867           
  Partials               ?      24598           
Flag Coverage Δ
integration 38.9887% <0.0000%> (?)
unit 72.6663% <75.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9278% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 63.3471% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GMHDBJD
Copy link
Contributor

GMHDBJD commented Jun 30, 2025

/retest

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 30, 2025
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 1, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 1, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-30 12:48:56.025260566 +0000 UTC m=+1312788.748439548: ☑️ agreed by GMHDBJD.
  • 2025-07-01 01:12:28.942767536 +0000 UTC m=+1357401.665946518: ☑️ agreed by Benjamin2037.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, GMHDBJD, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 3, 2025
@tangenta
Copy link
Contributor

/retest

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 11, 2025

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test 7b1ff03 link true /test unit-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@GMHDBJD
Copy link
Contributor

GMHDBJD commented Jul 11, 2025

pick in #62288

@GMHDBJD GMHDBJD closed this Jul 11, 2025
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Jul 14, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 14, 2025

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved do-not-merge/cherry-pick-not-approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants