Skip to content

executor: minor cleanup in builder.go#61924

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
zimulala:zimuxia/tiny-clean
Jun 23, 2025
Merged

executor: minor cleanup in builder.go#61924
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
zimulala:zimuxia/tiny-clean

Conversation

@zimulala
Copy link
Contributor

@zimulala zimulala commented Jun 23, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: ref: #61967

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 23, 2025
@zimulala zimulala added skip-issue-check Indicates that a PR no need to check linked issue. and removed do-not-merge/needs-linked-issue labels Jun 23, 2025
@tiprow
Copy link

tiprow bot commented Jun 23, 2025

Hi @zimulala. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented Jun 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.9463%. Comparing base (0dc591e) to head (183c50e).
Report is 5 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #61924        +/-   ##
================================================
+ Coverage   73.0048%   74.9463%   +1.9414%     
================================================
  Files          1735       1781        +46     
  Lines        481438     489860      +8422     
================================================
+ Hits         351473     367132     +15659     
+ Misses       108409      99750      -8659     
- Partials      21556      22978      +1422
Flag Coverage Δ
integration 48.9307% <85.7142%> (?)
unit 72.3192% <100.0000%> (+0.0703%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 62.5960% <ø> (+16.0101%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 23, 2025
@zimulala
Copy link
Contributor Author

zimulala commented Jun 23, 2025

/retest

@tiprow
Copy link

tiprow bot commented Jun 23, 2025

@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [AilinKid,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 23, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 23, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-23 06:03:41.518488811 +0000 UTC m=+683674.241667837: ☑️ agreed by hawkingrei.
  • 2025-06-23 09:11:30.026650325 +0000 UTC m=+694942.749829309: ☑️ agreed by AilinKid.

@hawkingrei
Copy link
Member

hawkingrei commented Jun 23, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit 1448932 into pingcap:master Jun 23, 2025
24 checks passed
@zimulala zimulala deleted the zimuxia/tiny-clean branch June 23, 2025 12:05
morgo added a commit to morgo/tidb that referenced this pull request Jun 24, 2025
@morgo
Merge remote-tracking branch 'origin/master' into identifier-in-default
46a19f4 
* origin/master: (129 commits)
  domain: Fix the issue that the min start ts doesn't correctly block keyspace-level GC (pingcap#61925)
  br: better control pd scheduler pause during log restore with filter (pingcap#61819)
  session: rename circuit breaker sysvar (pingcap#61951)
  dxfservice: create store for SYSTEM keyspace (pingcap#61752)
  docs: fix a dead link in CONTRIBUTORS.md (pingcap#61923)
  metrics/nextgengrafana: display keyspace separately (pingcap#61823)
  lightning: fix length check may be skipped for first line (pingcap#61874)
  planner: support `explain [analyze] <plan_digest>` for `explain explore` (pingcap#61942)
  planner: record explored plans into `tidb_statement_stats` when running `explain explore` (pingcap#61850)
  fix(runaway): ensure DistSQLContext's checker is synchronized with session variables (pingcap#61907)
  expression,planner: reuse the propOuterJoinConstSolver to improve performance (pingcap#61913)
  ddl,planner: remove unused and meaningless code (pingcap#61936)
  planner: remove unused field from physicalTableScan. (pingcap#61935)
  workload-learning: Extract metrics from cluster statements stats (pingcap#61378)
  executor: minor cleanup in builder.go (pingcap#61924)
  session: rename GetDomainInfoSchema to GetLatestInfoSchema (pingcap#61894)
  ingest: retry failed regions when batch scatter regions (pingcap#61722)
  planner: add tpch q1,q2,q3 benchmark (pingcap#61898)
  planner: fix uninit timeout for loading bindings (pingcap#61891)
  executor: report error when admin check on multiple tables (pingcap#61828)
  ...
@zimulala zimulala mentioned this pull request Jun 28, 2025
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@AilinKid AilinKid AilinKid approved these changes

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zimulala @hawkingrei @AilinKid