Skip to content

docs: fix a dead link in CONTRIBUTORS.md#61923

Merged
ti-chi-bot[bot] merged 3 commits intopingcap:masterfrom
yihong0618:hy/fix_dead_link
Jun 24, 2025
Merged

docs: fix a dead link in CONTRIBUTORS.md#61923
ti-chi-bot[bot] merged 3 commits intopingcap:masterfrom
yihong0618:hy/fix_dead_link

Conversation

@yihong0618
Copy link
Contributor

@yihong0618 yihong0618 commented Jun 23, 2025 •
edited by hawkingrei
Loading

As diff fix a dead link and the same as https://github.com/pingcap/docs/blob/885805fa1a37a375a47d5370f4c57d5c908dac3d/credits.md?plain=1#L14

Issue Number: close #xxx

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@yihong0618
docs: fix a dead link in CONTRIBUTORS.md
94411e5 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 23, 2025

Hi @yihong0618. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 23, 2025
@tiprow
Copy link

tiprow bot commented Jun 23, 2025

Hi @yihong0618. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hawkingrei
Copy link
Member

hawkingrei commented Jun 23, 2025

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jun 23, 2025
@hawkingrei hawkingrei added skip-issue-check Indicates that a PR no need to check linked issue. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. and removed ok-to-test Indicates a PR is ready to be tested. labels Jun 23, 2025
@hawkingrei hawkingrei added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jun 23, 2025
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 23, 2025
@hawkingrei hawkingrei requested a review from lance6716 June 23, 2025 06:17
lance6716
lance6716 reviewed Jun 23, 2025
View reviewed changes
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't remember what's the content of the old link. Maybe we can link to https://ossinsight.io/analyze/pingcap/tidb#contributors ?

PTAL @lilin90 @qiancai

@yihong0618
Copy link
Contributor Author

yihong0618 commented Jun 23, 2025

I didn't remember what's the content of the old link. Maybe we can link to https://ossinsight.io/analyze/pingcap/tidb#contributors ?

PTAL @lilin90 @qiancai

better
will change if agree

@yihong0618
docs: address comments
ff0205d 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
lilin90
lilin90 reviewed Jun 24, 2025
View reviewed changes
@yihong0618
docs: address the comments drop useless file
1bbf359 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@yihong0618 yihong0618 requested a review from lilin90 June 24, 2025 04:49
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 24, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 24, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-23 06:06:59.453974118 +0000 UTC m=+683872.177153102: ☑️ agreed by hawkingrei.
  • 2025-06-24 05:08:45.657927823 +0000 UTC m=+766778.381106804: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit 6803324 into pingcap:master Jun 24, 2025
5 checks passed
morgo added a commit to morgo/tidb that referenced this pull request Jun 24, 2025
@morgo
Merge remote-tracking branch 'origin/master' into identifier-in-default
46a19f4 
* origin/master: (129 commits)
  domain: Fix the issue that the min start ts doesn't correctly block keyspace-level GC (pingcap#61925)
  br: better control pd scheduler pause during log restore with filter (pingcap#61819)
  session: rename circuit breaker sysvar (pingcap#61951)
  dxfservice: create store for SYSTEM keyspace (pingcap#61752)
  docs: fix a dead link in CONTRIBUTORS.md (pingcap#61923)
  metrics/nextgengrafana: display keyspace separately (pingcap#61823)
  lightning: fix length check may be skipped for first line (pingcap#61874)
  planner: support `explain [analyze] <plan_digest>` for `explain explore` (pingcap#61942)
  planner: record explored plans into `tidb_statement_stats` when running `explain explore` (pingcap#61850)
  fix(runaway): ensure DistSQLContext's checker is synchronized with session variables (pingcap#61907)
  expression,planner: reuse the propOuterJoinConstSolver to improve performance (pingcap#61913)
  ddl,planner: remove unused and meaningless code (pingcap#61936)
  planner: remove unused field from physicalTableScan. (pingcap#61935)
  workload-learning: Extract metrics from cluster statements stats (pingcap#61378)
  executor: minor cleanup in builder.go (pingcap#61924)
  session: rename GetDomainInfoSchema to GetLatestInfoSchema (pingcap#61894)
  ingest: retry failed regions when batch scatter regions (pingcap#61722)
  planner: add tpch q1,q2,q3 benchmark (pingcap#61898)
  planner: fix uninit timeout for loading bindings (pingcap#61891)
  executor: report error when admin check on multiple tables (pingcap#61828)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lance6716 lance6716 lance6716 approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@lilin90 lilin90 Awaiting requested review from lilin90

Assignees

No one assigned

Labels

approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yihong0618 @hawkingrei @lance6716 @lilin90