Skip to content

planner: record explored plans into tidb_statement_stats when running explain explore#61850

Merged
ti-chi-bot[bot] merged 7 commits intopingcap:masterfrom
qw4990:explain-explore-stmt-stats
Jun 23, 2025
Merged

planner: record explored plans into tidb_statement_stats when running explain explore#61850
ti-chi-bot[bot] merged 7 commits intopingcap:masterfrom
qw4990:explain-explore-stmt-stats

Conversation

@qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jun 19, 2025

What problem does this PR solve?

Issue Number: ref #60148

Problem Summary: planner: record explored plans into tidb_statement_stats when running explain explore

What changed and how does it work?

planner: record explored plans into tidb_statement_stats when running explain explore

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 19, 2025
@tiprow
Copy link

tiprow bot commented Jun 19, 2025

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented Jun 19, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 12 lines in your changes missing coverage. Please review.

Project coverage is 73.6865%. Comparing base (ffaec74) to head (4636a70).
Report is 12 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #61850        +/-   ##
================================================
+ Coverage   73.0327%   73.6865%   +0.6538%     
================================================
  Files          1735       1735                
  Lines        481435     484198      +2763     
================================================
+ Hits         351605     356789      +5184     
+ Misses       108298     105904      -2394     
+ Partials      21532      21505        -27
Flag Coverage Δ
integration 42.4880% <8.3333%> (?)
unit 72.5163% <66.6666%> (+0.2528%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 47.0424% <ø> (+0.4591%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 20, 2025
terry1purcell
terry1purcell approved these changes Jun 21, 2025
View reviewed changes
Copy link
Contributor

@terry1purcell terry1purcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 21, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 21, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-20 23:55:26.868372179 +0000 UTC m=+488779.591551162: ☑️ agreed by henrybw.
  • 2025-06-21 01:50:37.805045816 +0000 UTC m=+495690.528224798: ☑️ agreed by terry1purcell.

@tiprow
Copy link

tiprow bot commented Jun 21, 2025

@qw4990: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow a27f460 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 23, 2025
qw4990
qw4990 commented Jun 23, 2025
View reviewed changes
pkg/bindinfo/testdata/binding_auto_suite_out.json
{
"SQL": "explain explore select * from t1, t2, t3",
"Plan": [
[
Copy link
Contributor Author

@qw4990 qw4990 Jun 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected, can't reproduce these plans through hints.

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 23, 2025

/test unit-test

@tiprow
Copy link

tiprow bot commented Jun 23, 2025

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 23, 2025

/retest

@tiprow
Copy link

tiprow bot commented Jun 23, 2025

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benmeadowcroft, hawkingrei, henrybw, terry1purcell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 23, 2025
@ti-chi-bot ti-chi-bot bot merged commit 52ca7d4 into pingcap:master Jun 23, 2025
22 checks passed
morgo added a commit to morgo/tidb that referenced this pull request Jun 24, 2025
@morgo
Merge remote-tracking branch 'origin/master' into identifier-in-default
46a19f4 
* origin/master: (129 commits)
  domain: Fix the issue that the min start ts doesn't correctly block keyspace-level GC (pingcap#61925)
  br: better control pd scheduler pause during log restore with filter (pingcap#61819)
  session: rename circuit breaker sysvar (pingcap#61951)
  dxfservice: create store for SYSTEM keyspace (pingcap#61752)
  docs: fix a dead link in CONTRIBUTORS.md (pingcap#61923)
  metrics/nextgengrafana: display keyspace separately (pingcap#61823)
  lightning: fix length check may be skipped for first line (pingcap#61874)
  planner: support `explain [analyze] <plan_digest>` for `explain explore` (pingcap#61942)
  planner: record explored plans into `tidb_statement_stats` when running `explain explore` (pingcap#61850)
  fix(runaway): ensure DistSQLContext's checker is synchronized with session variables (pingcap#61907)
  expression,planner: reuse the propOuterJoinConstSolver to improve performance (pingcap#61913)
  ddl,planner: remove unused and meaningless code (pingcap#61936)
  planner: remove unused field from physicalTableScan. (pingcap#61935)
  workload-learning: Extract metrics from cluster statements stats (pingcap#61378)
  executor: minor cleanup in builder.go (pingcap#61924)
  session: rename GetDomainInfoSchema to GetLatestInfoSchema (pingcap#61894)
  ingest: retry failed regions when batch scatter regions (pingcap#61722)
  planner: add tpch q1,q2,q3 benchmark (pingcap#61898)
  planner: fix uninit timeout for loading bindings (pingcap#61891)
  executor: report error when admin check on multiple tables (pingcap#61828)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@terry1purcell terry1purcell terry1purcell approved these changes

+2 more reviewers

@henrybw henrybw henrybw approved these changes

@benmeadowcroft benmeadowcroft benmeadowcroft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@qw4990 @henrybw @benmeadowcroft @hawkingrei @terry1purcell