Skip to content

executor: report error when admin check on multiple tables | tidb-test=pr/2534#61828

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
tangenta:admin-check-limit-1
Jun 23, 2025
Merged

executor: report error when admin check on multiple tables | tidb-test=pr/2534#61828
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
tangenta:admin-check-limit-1

Conversation

@tangenta
Copy link
Contributor

@tangenta tangenta commented Jun 19, 2025

What problem does this PR solve?

Issue Number: close #61827

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@tangenta
executor: report error when admin check on multiple tables
466b94e 
Signed-off-by: tangenta <tangenta@126.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 19, 2025
@tiprow
Copy link

tiprow bot commented Jun 19, 2025

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented Jun 19, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.3788%. Comparing base (8e6d77a) to head (466b94e).
⚠️ Report is 892 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #61828        +/-   ##
================================================
+ Coverage   73.0498%   75.3788%   +2.3290%     
================================================
  Files          1730       1782        +52     
  Lines        481655     495691     +14036     
================================================
+ Hits         351848     373646     +21798     
+ Misses       108260      98937      -9323     
- Partials      21547      23108      +1561
Flag Coverage Δ
integration 49.2141% <0.0000%> (?)
unit 72.7418% <100.0000%> (+0.4534%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 63.1860% <ø> (+16.6053%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tangenta tangenta changed the title executor: report error when admin check on multiple tables executor: report error when admin check on multiple tables | tidb-test=pr/2534 Jun 20, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 20, 2025
Benjamin2037
Benjamin2037 approved these changes Jun 20, 2025
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 20, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 20, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-20 03:05:02.343346065 +0000 UTC m=+413755.066525047: ☑️ agreed by wjhuang2016.
  • 2025-06-20 03:15:40.595703432 +0000 UTC m=+414393.318882415: ☑️ agreed by Benjamin2037.

@tangenta
Copy link
Contributor Author

tangenta commented Jun 20, 2025

/retest

@tiprow
Copy link

tiprow bot commented Jun 20, 2025

@tangenta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tangenta
Copy link
Contributor Author

tangenta commented Jun 20, 2025

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jun 20, 2025
@tangenta
Copy link
Contributor Author

tangenta commented Jun 21, 2025

/retest

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, hawkingrei, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 23, 2025
@tangenta
Copy link
Contributor Author

tangenta commented Jun 23, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit 0dc591e into pingcap:master Jun 23, 2025
27 checks passed
morgo added a commit to morgo/tidb that referenced this pull request Jun 24, 2025
@morgo
Merge remote-tracking branch 'origin/master' into identifier-in-default
46a19f4 
* origin/master: (129 commits)
  domain: Fix the issue that the min start ts doesn't correctly block keyspace-level GC (pingcap#61925)
  br: better control pd scheduler pause during log restore with filter (pingcap#61819)
  session: rename circuit breaker sysvar (pingcap#61951)
  dxfservice: create store for SYSTEM keyspace (pingcap#61752)
  docs: fix a dead link in CONTRIBUTORS.md (pingcap#61923)
  metrics/nextgengrafana: display keyspace separately (pingcap#61823)
  lightning: fix length check may be skipped for first line (pingcap#61874)
  planner: support `explain [analyze] <plan_digest>` for `explain explore` (pingcap#61942)
  planner: record explored plans into `tidb_statement_stats` when running `explain explore` (pingcap#61850)
  fix(runaway): ensure DistSQLContext's checker is synchronized with session variables (pingcap#61907)
  expression,planner: reuse the propOuterJoinConstSolver to improve performance (pingcap#61913)
  ddl,planner: remove unused and meaningless code (pingcap#61936)
  planner: remove unused field from physicalTableScan. (pingcap#61935)
  workload-learning: Extract metrics from cluster statements stats (pingcap#61378)
  executor: minor cleanup in builder.go (pingcap#61924)
  session: rename GetDomainInfoSchema to GetLatestInfoSchema (pingcap#61894)
  ingest: retry failed regions when batch scatter regions (pingcap#61722)
  planner: add tpch q1,q2,q3 benchmark (pingcap#61898)
  planner: fix uninit timeout for loading bindings (pingcap#61891)
  executor: report error when admin check on multiple tables (pingcap#61828)
  ...
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Nov 28, 2025
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 28, 2025

In response to a cherrypick label: new pull request created to branch release-8.5: #64748.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 28, 2025
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

Assignees

No one assigned

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

admin check cannot check multiple tables

5 participants

@tangenta @ti-chi-bot @hawkingrei @Benjamin2037 @wjhuang2016