Skip to content

lightning: added retry times and two new retry reasons(#60839)#62063

Merged
ti-chi-bot[bot] merged 5 commits intopingcap:release-8.1from
ti-chi-bot:cherry-pick-60839-to-release-8.1
Jul 16, 2025
Merged

lightning: added retry times and two new retry reasons(#60839)#62063
ti-chi-bot[bot] merged 5 commits intopingcap:release-8.1from
ti-chi-bot:cherry-pick-60839-to-release-8.1

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #60839

What problem does this PR solve?

Issue Number: ref #60077

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Jun 27, 2025
@ti-chi-bot
Copy link
Member Author

@GMHDBJD This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@GMHDBJD GMHDBJD changed the title lightning: added retry times and two new retry reasons | tidb-test=release-8.1.2 (#60839) lightning: added retry times and two new retry reasons(#60839) Jun 27, 2025
@GMHDBJD
Copy link
Contributor

GMHDBJD commented Jun 30, 2025

/retest

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 30, 2025
@codecov
Copy link

codecov bot commented Jun 30, 2025

Codecov Report

Attention: Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.1@61d7f3c). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #62063   +/-   ##
================================================
  Coverage               ?   71.2238%           
================================================
  Files                  ?       1469           
  Lines                  ?     424463           
  Branches               ?          0           
================================================
  Hits                   ?     302319           
  Misses                 ?     101584           
  Partials               ?      20560           
Flag Coverage Δ
unit 71.2238% <86.2069%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.5556% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 1, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 1, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-30 12:49:07.444086858 +0000 UTC m=+1312800.167265862: ☑️ agreed by GMHDBJD.
  • 2025-07-01 01:13:00.383886478 +0000 UTC m=+1357433.107065517: ☑️ agreed by Benjamin2037.

@GMHDBJD
Copy link
Contributor

GMHDBJD commented Jul 3, 2025

/retest

@ti-chi-bot ti-chi-bot bot added the approved label Jul 3, 2025
@GMHDBJD
Copy link
Contributor

GMHDBJD commented Jul 8, 2025

/retest

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 8, 2025
@GMHDBJD GMHDBJD force-pushed the cherry-pick-60839-to-release-8.1 branch from f2eb214 to 9e1c5e6 Compare July 11, 2025 07:13
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 11, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, GMHDBJD, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GMHDBJD
Copy link
Contributor

GMHDBJD commented Jul 15, 2025

/retest

@GMHDBJD
Copy link
Contributor

GMHDBJD commented Jul 15, 2025

/test unit-test

@tiprow
Copy link

tiprow bot commented Jul 15, 2025

@GMHDBJD: No presubmit jobs available for pingcap/tidb@release-8.1

Details

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tangenta tangenta removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2025
@GMHDBJD
Copy link
Contributor

GMHDBJD commented Jul 16, 2025

/retest

@GMHDBJD
Copy link
Contributor

GMHDBJD commented Jul 16, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit ee4368a into pingcap:release-8.1 Jul 16, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants