Skip to content

feat: add support for all browsers supported by playwright#18

Merged
pietdevries94 merged 1 commit intopietdevries94:mainfrom
bitbloxhub:all-browsers
Mar 10, 2026
Merged

feat: add support for all browsers supported by playwright#18
pietdevries94 merged 1 commit intopietdevries94:mainfrom
bitbloxhub:all-browsers

Conversation

@bitbloxhub
Copy link
Collaborator

Ports the changes from NixOS/nixpkgs#298944 and other subsequent fixes to this flake.

Fixes #7

@pietdevries94
Copy link
Owner

Thank you so much for this work! Is there anything I can do to help you get this to the finish line?

@bitbloxhub
Copy link
Collaborator Author

Mostly, I'm just blocked on waiting for NixOS/nixpkgs#470230 to get merged so update.sh works. I found the line that updates the version in driver.nix in the old update.sh, and i just need to port that. (Also i need to actually TEST that these drivers work, but i can do that, at least for linux.)

@bitbloxhub
Copy link
Collaborator Author

bitbloxhub commented Dec 15, 2025

Alright, nix run ".#playwright-test" -- {cr,ff} https://github.com works on linux. nix run ".#playwright-test" -- wk https://github.com errors with Cannot find a MiniBrowser.app in neither location, but this happens with the nixpkgs version as well, and seems to be related to not running it headless.

@bitbloxhub bitbloxhub marked this pull request as ready for review December 16, 2025 18:37
@Crocmagnon
Copy link

Hello,
Thank you for this PR!
Is there any chance to have this backported to already released driver versions?

@bitbloxhub
Copy link
Collaborator Author

bitbloxhub commented Dec 22, 2025

@Crocmagnon

Is there any chance to have this backported to already released driver versions?

Since the driver versions are tags and not branches, probably not unless @pietdevries94 can do it, which should be fairly easy once the update script works (just replace driver_version with the version you want). For running the update script yourself, run bash update.sh inside a Nix shell with all the packages in the shebang except use github:Titaniumtown/nixpkgs/fix/nix-prefetch-extendmkderivation#nix-prefetch instead of upstream nixpkgs#nix-prefetch for now.

@pietdevries94
Copy link
Owner

pietdevries94 commented Dec 24, 2025

I am currently moving house, preventing me from putting in the time at the moment to review these changes. I want to give this the attention it deserves!

My late response doesn’t mean I am lacklustre about this change. I absolutely am committed to this, and am thankful for this pull request!

I am fully ok with backporting this on demand, since there has been changes to the paths in the past, the testing must be done then too.

@bitbloxhub
Copy link
Collaborator Author

bitbloxhub commented Feb 9, 2026

Looks like they broke some of the driver URLs, can't seem to find the new ones. This seems to affect the main branch as well.

Ports the changes from NixOS/nixpkgs#298944 and
other subsequent fixes to this flake.

Fixes pietdevries94#7
@bitbloxhub
Copy link
Collaborator Author

Fixed it for 1.58.2, see https://github.com/NixOS/nixpkgs/pull/498142/changes as a source for more of my changes.

@pietdevries94
Copy link
Owner

@bitbloxhub Hey, thank you so much for your effort in this repository. Because my personal life is rather tumultuous, I haven't been able to put in much time in work as this. I would love for you to become a maintainer on this repository, so people can make use of your work more broadly, without me being in the way! :) I can understand if you want to discuss this further in private before committing to that. My email is the same as my github name, @gmail.com , and I also am available for dms on bluesky (@piet.eurosky.social)

@bitbloxhub
Copy link
Collaborator Author

I would love for you to become a maintainer on this repository

Sure, I can at least handle backporting changes from nixpkgs like in this PR, although I don't have quite as much interest in playwright as when I opened this PR (switched from vitest to Japa+WDIO for tests).

@pietdevries94
Copy link
Owner

I sadly have a similar situation haha 😅 But I like the effort you put in. I'll add you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Firefox and Webkit

3 participants