feat: add support for all browsers supported by playwright#18
feat: add support for all browsers supported by playwright#18pietdevries94 merged 1 commit intopietdevries94:mainfrom
Conversation
|
Thank you so much for this work! Is there anything I can do to help you get this to the finish line? |
|
Mostly, I'm just blocked on waiting for NixOS/nixpkgs#470230 to get merged so |
e6a6d15 to
3f1a665
Compare
|
Alright, |
3f1a665 to
4b0b629
Compare
|
Hello, |
Since the driver versions are tags and not branches, probably not unless @pietdevries94 can do it, which should be fairly easy once the update script works (just replace |
|
I am currently moving house, preventing me from putting in the time at the moment to review these changes. I want to give this the attention it deserves! My late response doesn’t mean I am lacklustre about this change. I absolutely am committed to this, and am thankful for this pull request! I am fully ok with backporting this on demand, since there has been changes to the paths in the past, the testing must be done then too. |
4b0b629 to
dab6e56
Compare
dab6e56 to
a2413a1
Compare
|
Looks like they broke some of the driver URLs, can't seem to find the new ones. This seems to affect the main branch as well. |
Ports the changes from NixOS/nixpkgs#298944 and other subsequent fixes to this flake. Fixes pietdevries94#7
|
Fixed it for 1.58.2, see https://github.com/NixOS/nixpkgs/pull/498142/changes as a source for more of my changes. |
|
@bitbloxhub Hey, thank you so much for your effort in this repository. Because my personal life is rather tumultuous, I haven't been able to put in much time in work as this. I would love for you to become a maintainer on this repository, so people can make use of your work more broadly, without me being in the way! :) I can understand if you want to discuss this further in private before committing to that. My email is the same as my github name, @gmail.com , and I also am available for dms on bluesky (@piet.eurosky.social) |
Sure, I can at least handle backporting changes from nixpkgs like in this PR, although I don't have quite as much interest in playwright as when I opened this PR (switched from vitest to Japa+WDIO for tests). |
|
I sadly have a similar situation haha 😅 But I like the effort you put in. I'll add you :) |
Ports the changes from NixOS/nixpkgs#298944 and other subsequent fixes to this flake.
Fixes #7