fix: correct aarch64-linux headless shell browser path#17
Draft
pietdevries94 wants to merge 1 commit intopietdevries94:mainfrom
Draft
fix: correct aarch64-linux headless shell browser path#17pietdevries94 wants to merge 1 commit intopietdevries94:mainfrom
pietdevries94 wants to merge 1 commit intopietdevries94:mainfrom
Conversation
The aarch64-linux headless shell browser was incorrectly configured: 1. mkdir used `chromium-headless-shell-` (dashes) but makeWrapper used `chromium_headless_shell-` (underscores) - now both use underscores 2. makeWrapper used $CHROMIUM_REVISION instead of $CHROMIUM_HEADLESS_SHELL_REVISION - now uses correct variable 3. Binary was named `chrome` instead of `headless_shell` - Playwright expects `headless_shell` at this path Without this fix, Playwright fails on aarch64-linux with: Executable doesn't exist at .../chromium_headless_shell-1200/chrome-linux/headless_shell
Owner
Author
|
@justinmoon Did this actually fix your problem? If so, I would like to upstream it :) |
|
Yes it did. I have just been using my fork and it's working very smoothly. NOTE: I vibe-coded the fix and don't understand it. So buyer beware! This is why I haven't attempted to upstream, yet. Thanks for making this tool, btw, it has been extremely helpful for me! |
Collaborator
|
@justinmoon, does the new main branch after #18 and #21 work for you? Just wondering if I can close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aarch64-linux headless shell browser was incorrectly configured:
mkdir used
chromium-headless-shell-(dashes) but makeWrapper usedchromium_headless_shell-(underscores) - now both use underscoresmakeWrapper used $CHROMIUM_REVISION instead of $CHROMIUM_HEADLESS_SHELL_REVISION - now uses correct variable
Binary was named
chromeinstead ofheadless_shell- Playwright expectsheadless_shellat this pathWithout this fix, Playwright fails on aarch64-linux with:
Executable doesn't exist at .../chromium_headless_shell-1200/chrome-linux/headless_shell