nix-prefetch: fix compatibility with extendMkDerivation-based fetchers#470230
Merged
mdaniels5757 merged 1 commit intoNixOS:masterfrom Dec 23, 2025
Merged
Conversation
bitbloxhub
approved these changes
Dec 15, 2025
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2690 |
Member
|
mdaniels5757
approved these changes
Dec 23, 2025
Member
mdaniels5757
left a comment
There was a problem hiding this comment.
Approved automatically following the successful run of nixpkgs-review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was running into the issue, when running
./pkgs/development/python-modules/playwright/update.shto update playwright. It seemed nix-prefetch didn't like being called on fetchers that used extendMkDerivation, resulting in a "expected a set but found a function" error. Nix-prefetch always assumes that fetcher arguments will always be attribute sets, but in reality we are passing functions to them.For transparency's sake, I used Claude Opus 4.5 to actually root cause this issue because I didn't have a grasp on the issue I was encountering.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.