Skip to content

nix-prefetch: fix compatibility with extendMkDerivation-based fetchers#470230

Merged
mdaniels5757 merged 1 commit intoNixOS:masterfrom
Titaniumtown:fix/nix-prefetch-extendmkderivation
Dec 23, 2025
Merged

nix-prefetch: fix compatibility with extendMkDerivation-based fetchers#470230
mdaniels5757 merged 1 commit intoNixOS:masterfrom
Titaniumtown:fix/nix-prefetch-extendmkderivation

Conversation

@Titaniumtown
Copy link
Contributor

I was running into the issue, when running ./pkgs/development/python-modules/playwright/update.sh to update playwright. It seemed nix-prefetch didn't like being called on fetchers that used extendMkDerivation, resulting in a "expected a set but found a function" error. Nix-prefetch always assumes that fetcher arguments will always be attribute sets, but in reality we are passing functions to them.

For transparency's sake, I used Claude Opus 4.5 to actually root cause this issue because I didn't have a grasp on the issue I was encountering.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot requested a review from msteen December 12, 2025 20:00
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Dec 12, 2025
Copy link
Contributor

@bitbloxhub bitbloxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these changes make sense and work.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2690

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Dec 15, 2025
@mdaniels5757
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 470230
Commit: 030e2797323d4f24d335be2c659ec3c1376e4f63 (subsequent changes)
Merge: 4c6d09511fa258125bee36009a4cda78e399fa47

Logs: https://github.com/mdaniels5757/nixpkgs-review-gha/actions/runs/20464688225

Download packages from cache:
  • x86_64-linux
    nix-store -r --add-root nixpkgs-pr-470230-x86_64-linux \
      --option binary-caches 'https://cache.nixos.org/ https://mdaniels5757-nix.cachix.org' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      mdaniels5757-nix.cachix.org-1:iT2D2XMbTS301DFoC8sTOSP86fXMPiGrvPnrEsQN5uo=
      ' \
      /nix/store/c49wc8029wrv979vy7kc1c1ijghx4nlb-nim_lk-20250309 \
      /nix/store/r97f83y6xr4ji435b4x7kfb459l4rw3p-nix-prefetch-0.4.1
  • aarch64-linux
    nix-store -r --add-root nixpkgs-pr-470230-aarch64-linux \
      --option binary-caches 'https://cache.nixos.org/ https://mdaniels5757-nix.cachix.org' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      mdaniels5757-nix.cachix.org-1:iT2D2XMbTS301DFoC8sTOSP86fXMPiGrvPnrEsQN5uo=
      ' \
      /nix/store/zqad0qny1p6jm6l8vcan7ylb6y1ch2yc-nim_lk-20250309 \
      /nix/store/bm2f2yf58klndr2jkqlh2yl8vylp5kfp-nix-prefetch-0.4.1
  • x86_64-darwin
    nix-store -r --add-root nixpkgs-pr-470230-x86_64-darwin \
      --option binary-caches 'https://cache.nixos.org/ https://mdaniels5757-nix.cachix.org' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      mdaniels5757-nix.cachix.org-1:iT2D2XMbTS301DFoC8sTOSP86fXMPiGrvPnrEsQN5uo=
      ' \
      /nix/store/ibkcyq0mlpnrbvbcy5zkm6d81h4qmnri-nim_lk-20250309 \
      /nix/store/0hi5f22him29vhcr2i87s3q2iyb9j8k8-nix-prefetch-0.4.1
  • aarch64-darwin
    nix-store -r --add-root nixpkgs-pr-470230-aarch64-darwin \
      --option binary-caches 'https://cache.nixos.org/ https://mdaniels5757-nix.cachix.org' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      mdaniels5757-nix.cachix.org-1:iT2D2XMbTS301DFoC8sTOSP86fXMPiGrvPnrEsQN5uo=
      ' \
      /nix/store/rlm55c10yxmkbxiwqwf3k792jrysw25x-nim_lk-20250309 \
      /nix/store/dncixpn8labrbs1k3wy5xvbxfzk94ihz-nix-prefetch-0.4.1

x86_64-linux

✅ 2 packages built:
  • nim_lk
  • nix-prefetch

aarch64-linux

✅ 2 packages built:
  • nim_lk
  • nix-prefetch

x86_64-darwin (sandbox = true)

✅ 2 packages built:
  • nim_lk
  • nix-prefetch

aarch64-darwin (sandbox = true)

✅ 2 packages built:
  • nim_lk
  • nix-prefetch

Copy link
Member

@mdaniels5757 mdaniels5757 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@mdaniels5757 mdaniels5757 added this pull request to the merge queue Dec 23, 2025
Merged via the queue into NixOS:master with commit 9ca21a5 Dec 23, 2025
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants