fix: clear asset genesis to prevent accounts referencing undefined assets#481
Closed
fix: clear asset genesis to prevent accounts referencing undefined assets#481
Conversation
…sets Prevents pallet_assets panic by clearing asset-related genesis fields when accounts have balances for assets that don't exist
Collaborator
|
Thanks @mchristou, I just commented here since I think we (zombienet) should only modify/remove keys needed to spawn the network. Here we can take the opposite approach and ensure that the account in assets is present since is a better dx for end users. Thx! |
Contributor
Author
Hi @pepoviola, yes that make sense. |
Contributor
Author
|
closing in favor of #482 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #480
When customizing parachain chain-specs, runtime presets may include
asset account balances for assets that are not defined in the genesis.
This causes pallet_assets genesis build to panic with "assertion failed:
result.is_ok()" when increase_balance() is called for non-existent assets.
Clear assets genesis data in clear_authorities()
to ensure accounts aren't assigned balances for undefined assets.