Fix penpal runtime & enable zombienet tests again.#10667
Closed
Fix penpal runtime & enable zombienet tests again.#10667
Conversation
pepoviola
reviewed
Dec 16, 2025
Comment on lines
+87
to
+89
| // Don't pre-fund accounts with non-sufficient assets at genesis | ||
| // They can be minted later if needed | ||
| accounts: vec![] |
Contributor
There was a problem hiding this comment.
We are making a similar fix in zombienet (paritytech/zombienet-sdk#481), but I think this is more accurate since the zombienet should only modify the needed keys to spawn the network.
cc: @mchristou
pepoviola
approved these changes
Dec 16, 2025
pepoviola
reviewed
Dec 16, 2025
| zombienet-polkadot-elastic-scaling-doesnt-break-parachains:10653 | ||
| zombienet-polkadot-smoke-0005-precompile-pvf-smoke:10653 | ||
| zombienet-polkadot-smoke-0004-coretime-smoke-test:10653 | ||
| zombienet-polkadot-smoke-0002-parachains-parachains-upgrade-smoke:10653 |
Contributor
There was a problem hiding this comment.
@eskimor / @sandreim, can we remove this test according to this comment #10654 (comment)
wdyt?
pepoviola
reviewed
Dec 16, 2025
| zombienet-polkadot-functional-0014-chunk-fetching-network-compatibility:9980 | ||
| # disabled until zombienet support penpal (https://github.com/paritytech/zombienet-sdk/issues/480) | ||
| zombienet-polkadot-shared-core-idle-parachain:10653 | ||
| zombienet-polkadot-functional-async-backing-6-seconds-rate:10653 |
Contributor
There was a problem hiding this comment.
@eskimor / @sandreim, can we remove this test according to #10654 (comment)
wdyt?
Contributor
There was a problem hiding this comment.
async backing should be fine to remove, but not so sure about core sharing.
eskimor
added
the
R0-no-crate-publish-required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issues with penpal runtime.