Skip to content

fix: clear asset genesis to prevent accounts referencing undefined assets #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mchristou wants to merge 2 commits into from
Closed

fix: clear asset genesis to prevent accounts referencing undefined assets #481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc5e303
fix: clear asset genesis to prevent accounts referencing undefined as…
mchristou Dec 16, 2025
5a29584
clippy
mchristou Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions crates/orchestrator/src/generators/chain_spec.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1328,6 +1328,13 @@ fn clear_authorities(
val["staking"]["validatorCount"] = json!(0);
}
}

// clear assets-related genesis data to avoid orphaned asset accounts
if val.get("assets").is_some() {
val["assets"]["assets"] = json!([]);
val["assets"]["metadata"] = json!([]);
val["assets"]["accounts"] = json!([]);
}
} else {
unreachable!("pointer to runtime config should be valid!")
}
Expand Down
28 changes: 15 additions & 13 deletions crates/orchestrator/src/network_spec.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,19 +249,21 @@ impl NetworkSpec {
try_join_all(
image_command_to_nodes_mapping
.keys()
.cloned()
.map(|(image, command)| async {
// get node available args output from image/command
let available_args = ns
.get_node_available_args((command.clone(), image.clone()))
.await?;
debug!(
"retrieved available args for image: {:?}, command: {}",
image, command
);

// map the result to include image and command
Ok::<_, OrchestratorError>((image, command, available_args))
.map(|(image, command)| {
let ns_cloned = ns.clone();
async move {
// get node available args output from image/command
let available_args = ns_cloned
.get_node_available_args((command.clone(), image.clone()))
.await?;
debug!(
"retrieved available args for image: {:?}, command: {}",
image, command
);

// map the result to include image and command
Ok::<_, OrchestratorError>((image.clone(), command.clone(), available_args))
}
})
.collect::<Vec<_>>(),
)
Expand Down
Loading