Skip to content

check assets accounts and add them to balances#482

Merged
pepoviola merged 4 commits intomainfrom
ensure-assets-works
Dec 22, 2025
Merged

check assets accounts and add them to balances#482
pepoviola merged 4 commits intomainfrom
ensure-assets-works

Conversation

@pepoviola
Copy link
Copy Markdown
Collaborator

Fix #480

  • Add logic to check the accounts on the assets pallets, and for each one ensure they are present by add them in balances
  • Refactor add_balances to be more flexible and just receive a map to insert.
  • Add unit tests

cc: @mchristou

@pepoviola pepoviola requested a review from mchristou December 18, 2025 09:28
}

fn generate_balance_to_add_from_nodes(
nodes: &Vec<NodeSpec>,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is more flexible to use &[NodeSpec]

// ensure zombie account (//Zombie) have funds
// we will use for internal usage (e.g new validators)
balances_to_add.push((
"5FTcLfwFc7ctvqp3RhbEig6UuHLHcHVRujuUm8r21wy4dAR8".to_string(),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use this account in multiple places, we can extract it into a constant

@pepoviola pepoviola merged commit c8f8c34 into main Dec 22, 2025
8 checks passed
@pepoviola pepoviola deleted the ensure-assets-works branch December 22, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] penpal doesn't works with the current customizations

2 participants