Merged
Conversation
lexnv
approved these changes
May 9, 2025
jsdw
commented
May 9, 2025
| name: Check documentation and run doc tests | ||
| runs-on: parity-large | ||
| needs: [fmt, machete] | ||
| timeout-minutes: 30 |
Collaborator
Author
There was a problem hiding this comment.
Incase doc tests hang again!
jsdw
commented
May 9, 2025
| /// Generating an interface using all of the defaults: | ||
| /// | ||
| /// ```rust | ||
| /// ```rust,standalone_crate |
Collaborator
Author
There was a problem hiding this comment.
Doc tests have been hanging in CI, and even locally, I think since I enabled Rust 2024. Rust 2024 changes how doc tests run and compiles them into a single binary ratehr than 1 per test.
Since many of our doc tests generate a load of code via the subxt macro, I suspect that this was eating up too much memory during compilation and causing the CI machine to hang (locally it went well over 4GB offhand).
Either way, adding standalone_crate to them all reverted to the previous behaviour which seems to work much better for us!
alvicsam
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[0.42.0] - 2025-05-09
The primary benefit of this release is introducing support for the about-to-be-stabilised-in-polkadot-sdk V16 metadata, and with that, support for calling Pallet View Functions on runtimes which will support this. Pallet View Functions are used much like Runtime APIs, except that they are declared in specific pallets and not declared at the runtime-wide level, allowing pallets to carry their own APIs with them.
Pallet View Functions
Calling a Pallet View Function in this Subxt release will look like:
Like Runtime APIs and others, the dynamic API can also be used to call into Pallet View Functions, which has the advantage of not needing the statically generated interface, but the downside of not being strongly typed. This looks like the following:
Updated
ConfigtraitAnother change to be aware of is that our
Configtrait has been tweaked. TheHashassociated type is no longer needed, as it can be obtained via theHasherassociated type already, andPolkadotConfig/SubstrateConfignow set the hasher by default to beDynamicHasher256, which will (when V16 metadata is available for a runtime) automatically select between Keccak256 and BlakeTwo256 hashers depending on what the chain requires.Other changes
We also solidify our support for V1 archive RPCs, upgrade the codebase to Rust 2024 edition, and a bunch of other changes, the full list of which is here:
Added
Changed
Fixed