Allow submitting transactions ignoring follow events#1962
Merged
Conversation
jsdw
commented
Mar 12, 2025
Comment on lines
+804
to
+814
| if self.submit_transactions_ignoring_follow_events { | ||
| submit_transaction_ignoring_follow_events(extrinsic, &self.methods).await | ||
| } else { | ||
| submit_transaction_tracking_follow_events::<T>( | ||
| extrinsic, | ||
| self.transaction_timeout_secs as u64, | ||
| &self.methods, | ||
| &self.follow_handle, | ||
| ) | ||
| .await | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
I just moved the existing logic into submit_transaction_tracking_follow_events and added an alternative path which is muc hsimpler for ignoring them
niklasad1
reviewed
Mar 13, 2025
| /// This can lead to errors when calling APIs like `wait_for_finalized_success`, which will try to retrieve events | ||
| /// at the finalized block, because there will be a race and the finalized block may not be available for querying | ||
| /// yet. | ||
| pub fn submit_transactions_ignoring_follow_events(mut self) -> Self { |
Contributor
There was a problem hiding this comment.
a little long name :)
I don't have a better suggestion in mind though
Collaborator
Author
There was a problem hiding this comment.
Yeah; it's quite long but also quite a rare thing to set I would hope, so I don't mind I guess!
niklasad1
approved these changes
Mar 13, 2025
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1956