Merged
Conversation
lexnv
approved these changes
Apr 1, 2025
Collaborator
|
Nice! Thanks for stabilizing and implementing these! 🙏 |
niklasad1
reviewed
Apr 1, 2025
| } | ||
|
|
||
| /// Call the `archive_v1_call` method and return the response. | ||
| pub async fn archive_v1_call( |
Contributor
There was a problem hiding this comment.
hmm, we could perhaps have a shared implementation for this for both archive_v1_call and archive_unstable_call but doesn't matter that much since we will remove the unstable stuff eventually :)
Collaborator
Author
There was a problem hiding this comment.
Yeah, I contemplated that, but then it'd make it messier to remove them, whereas at the mo we can just delete the unstable ones nice and cleanly :)
niklasad1
reviewed
Apr 1, 2025
| // Dev note: we continue to support the latest "unstable" archive methods because | ||
| // they will be around for a while before the stable ones make it into a release. | ||
| // The below are just a copy-paste of the v1 methods, above, but calling the | ||
| // "unstable" RPCs instead. Eventually we'll remove them. |
Contributor
There was a problem hiding this comment.
maybe open a tracking issue for that so we don't forget
niklasad1
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we've stabilized the archive RPCs, add support for v1 archive RPCs in subxt-rpcs.
We keep the
archive_unstablemethods as copies of the v1 ones which do the same thing, but when the v1 ones have been around a while we can delete them.